Closed Bug 1237441 Opened 4 years ago Closed 4 years ago

Move styleinspector directory into the shared directory

Categories

(DevTools :: Inspector, defect)

defect
Not set

Tracking

(firefox46 fixed)

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: gl, Assigned: gl)

References

Details

Attachments

(1 file, 3 obsolete files)

No description provided.
Depends on: 1235172
Attachment #8704997 - Flags: review?(pbrosset)
Attached patch 1237441.patch (obsolete) — Splinter Review
https://treeherder.mozilla.org/#/jobs?repo=try&revision=32d559f568ab
Attachment #8704997 - Attachment is obsolete: true
Attachment #8705328 - Flags: review?(pbrosset)
Attached patch 1237441.patch (obsolete) — Splinter Review
https://treeherder.mozilla.org/#/jobs?repo=try&revision=55c585492104
Attachment #8705328 - Attachment is obsolete: true
Attachment #8705328 - Flags: review?(pbrosset)
Attachment #8705348 - Flags: review?(pbrosset)
Comment on attachment 8705348 [details] [diff] [review]
1237441.patch

Review of attachment 8705348 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/inspector/shared/style-inspector-menu.js
@@ +2,5 @@
>  /* vim: set ts=2 et sw=2 tw=80: */
>  /* This Source Code Form is subject to the terms of the Mozilla Public
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> +/* global _strings */

Minor comment about this: I'd prefer not to add this, maintaining a list of globals in a comment is hard, it's bound to become obsolete at some stage, plus Mike had been working on an eslint plugin that imports things from Cu.import/lazyGetter/... automatically as eslint globals.
I'd rather we fix that plugin than start adding this comment.
Attachment #8705348 - Flags: review?(pbrosset) → review+
Backed out in https://hg.mozilla.org/integration/fx-team/rev/685c3cd62971 because :gl says it'll eventually cause build bustage.
Flags: needinfo?(gl)
Flags: needinfo?(gl)
https://hg.mozilla.org/mozilla-central/rev/7f93502bb587
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.