1237445 - Migrate more hashtable users to GC-aware versions, including those needing rekeying

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Steve Fink [:sfink] [:s:]]

Bug 1225298 went into the previous release cycle, so opening a new bug for the remaining landings.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Implement GCRekeyableHashMap

I still don't have everything working, but one big chunk is the things that required rekeying. This patch makes a GCRekeyableHashMap for those so I can land them in advance of any future rekeying removal.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 8704847 [details] [diff] [review]
Implement GCRekeyableHashMap

Review of attachment 8704847 [details] [diff] [review]:
-----------------------------------------------------------------

WFM

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d0643d45a74
https://hg.mozilla.org/integration/mozilla-inbound/rev/e003fb68a47c
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a2a11b4cee1
https://hg.mozilla.org/integration/mozilla-inbound/rev/28657e5774d0
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d93baf4ff9c

Comment 4

[Steve Fink [:sfink] [:s:]]

Note to anyone suspicious: the patches landing here are attached and marked r+ in bug 1225298.

Next time I'm going to use a constellation of separate bugs.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9d0643d45a74
https://hg.mozilla.org/mozilla-central/rev/e003fb68a47c
https://hg.mozilla.org/mozilla-central/rev/7a2a11b4cee1
https://hg.mozilla.org/mozilla-central/rev/28657e5774d0
https://hg.mozilla.org/mozilla-central/rev/5d93baf4ff9c

Comment 6

[Steve Fink [:sfink] [:s:]]

Attachment: Use GCHashSet for RegExpShared sweeping

This is the bug I wanted to use.

This is now a very minimal refactoring change to make it look more like GCHashSet without actually using GCHashSet (which I hope wouldn't compile at this point, since no zero-arg needsSweep is defined for RegExpShared so set_->sweep() can't be defined.)

Totally optional at this point. Pretty much irrelevant, since it'll be scrapped either way if we make RegExpShared into a gc thing.

Comment 7

[Terrence Cole [:terrence]]

Comment on attachment 8709606 [details] [diff] [review]
Use GCHashSet for RegExpShared sweeping

Review of attachment 8709606 [details] [diff] [review]:
-----------------------------------------------------------------

I like it.

::: js/src/vm/RegExpObject.cpp
@@ +828,5 @@
>              e.removeFront();
>          }
>      }
>  
>      if (matchResultTemplateObject_ &&

Just noticed that !set_.initialized() implies !matchResultTemplateObject_. Is it worth asserting this relation.

Comment 8

[Steve Fink [:sfink] [:s:]]

Attachment: Rekey ArrayObjectTable

As mentioned on IRC, this table still needs rekeying.

Comment 9

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8710012 [details] [diff] [review]
Rekey ArrayObjectTable

Gah. Wrong patch from wrong terminal.

Comment 10

[Steve Fink [:sfink] [:s:]]

Attachment: Rekey ArrayObjectTable

Ok, let's try this again.

Comment 11

[Terrence Cole [:terrence]]

Comment on attachment 8710016 [details] [diff] [review]
Rekey ArrayObjectTable

Review of attachment 8710016 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0b106a76c7f
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1153dc8ccd1
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8f94c805684

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d0b106a76c7f
https://hg.mozilla.org/mozilla-central/rev/c1153dc8ccd1
https://hg.mozilla.org/mozilla-central/rev/d8f94c805684

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d0b106a76c7f
https://hg.mozilla.org/mozilla-central/rev/c1153dc8ccd1
https://hg.mozilla.org/mozilla-central/rev/d8f94c805684