Use MOZ_RELEASE_ASSERT for IPC assertions

RESOLVED FIXED in Firefox 47

Status

()

Core
IPC
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

Trunk
mozilla47
Points:
---

Firefox Tracking Flags

(firefox46 affected, firefox47 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8704872 [details] [diff] [review]
patch

We have a lot of weird IPC crashes and I'd like to gather more information about them. I think the first step is to convert a lot of IPC assertions to release asserts. IPC code isn't performance-sensitive, so I think the only danger here is that these will trigger too often. If they do, we can always convert them back to regular assertions.
Attachment #8704872 - Flags: review?(jld)
Comment on attachment 8704872 [details] [diff] [review]
patch

Review of attachment 8704872 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable.  It would definitely be nice to get more insight into the sync response type mismatch crashes.
Attachment #8704872 - Flags: review?(jld) → review+

Comment 2

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ad4623f3840

Comment 3

2 years ago
Build bustage!
Flags: needinfo?(wmccloskey)

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9dd94eccd36a8bc910cba69b62f7c0c9974ec0aa
Backed out changeset 4ad4623f3840 (bug 1237458) for build bustage ON A CLOSED TREE

Comment 5

2 years ago
Build bustage on all opt platforms like this - https://treeherder.mozilla.org/logviewer.html#?job_id=19417451&repo=mozilla-inbound

Comment 6

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d358cdf1ce4
backed out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=21118184&repo=mozilla-inbound

Comment 8

2 years ago
Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1dbe350b57b1

Comment 9

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/734e3856f443

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/734e3856f443
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
(Assignee)

Updated

2 years ago
Flags: needinfo?(wmccloskey)
See Also: → bug 1120485
You need to log in before you can comment on or make changes to this bug.