Closed Bug 1237515 Opened 8 years ago Closed 8 years ago

[TV][2.5][Addon] Closing presentation session after TV receives command from fennec add-on

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.6 S5 - 1/15

People

(Reporter: chunmin, Assigned: chunmin)

References

Details

Attachments

(1 file, 1 obsolete file)

Fennec add-on needs to close the session after sending 'Open webpage' command to TV. Closing presentation session upon sending command on fennec side can't open webpage correctly. The reason might be that TV will close the session and cancel the corresponding action before actually executing the previous command.

Closing presentation session by TV after TV opening webpage successfully or sending a 'open-failed' message back to fennec add-on might solve the problem.
Component: Gaia → Gaia::TV
Attached patch close-session.patch (obsolete) — Splinter Review
Comment on attachment 8705014 [details] [diff] [review]
close-session.patch

Hi SC,
Is it ok that TV close the session after opening webpage successfully?
Attachment #8705014 - Flags: feedback?(schien)
Comment on attachment 8705014 [details] [diff] [review]
close-session.patch

Review of attachment 8705014 [details] [diff] [review]:
-----------------------------------------------------------------

I'll prefer TV side sending ack and connection closed by controlling side.
BTW, I'll suggest that you follow the naming rule in bug 1123183 comment #9, i.e. using { type: ‘ack' [, error: <error message>] }
Attachment #8705014 - Flags: feedback?(schien) → feedback-
Comment on attachment 8705486 [details] [review]
[gaia] ChunMinChang:bug-1237515 > mozilla-b2g:master

Hi Rex, 
I would appreciate it if you could review this patch.
Attachment #8705486 - Flags: review?(rexboy)
Attachment #8705014 - Attachment is obsolete: true
Comment on attachment 8705486 [details] [review]
[gaia] ChunMinChang:bug-1237515 > mozilla-b2g:master

Looks good to me.
Attachment #8705486 - Flags: review?(rexboy) → review+
Assignee: nobody → cchang
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/886bd7137c902ba453723dbbd9b981e01de86b43
Status: NEW → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S5 - 1/15
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: