Closed
Bug 1237566
Opened 8 years ago
Closed 8 years ago
Bake in global this value if possible in IonBuilder::jsop_functionthis
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
806 bytes,
patch
|
h4writer
:
review+
|
Details | Diff | Splinter Review |
If a non-strict function uses |this|, and the this-argument is undefined/null, it resolves to the global or the WindowProxy. Since bug 1125423, we can do the boxing in IonBuilder, but I forgot to do that there. It shows up in some benchmarks like Octane-TypeScript and sunspider 3d-cube.
Attachment #8705085 -
Flags: review?(hv1989)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8705085 [details] [diff] [review] Patch Review of attachment 8705085 [details] [diff] [review]: ----------------------------------------------------------------- That is handy.
Attachment #8705085 -
Flags: review?(hv1989) → review+
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/70094106841c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•