1237572 - Explore converting SWTableViewCell to Carthage

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Emily Toop (:fluffyemily)]

Can we make SWTableViewCell Carthage compliant, or can we find a Carthage compliant alternative?

Comment 1

[Farhan Patel [:farhan]]

I've spent some time looking for an alternative and found one in the default iOS SDK. This is the same approach that a lot of the built in iOS apps (like mail/Notes) use. 

The UI is slightly different and so I'd like to get Robin to have a look first to make sure its okay. 

I've attached a small video that has both the current behavior and then the new behavior. If this new behavior is acceptable we can remove about 1300 lines of code. ヽ(•‿•)ノ

Comment 2

[Farhan Patel [:farhan]]

Attachment: readinglist.mov

A before and after of the ReadingList action buttons.

Comment 3

[Robin Andersen [:tecgirl]]

This looks great, Farhan! GFI!

Comment 4

[Farhan Patel [:farhan]]

Attachment: Pull Request

Comment 5

[Emily Toop (:fluffyemily)]

Comment on attachment 8767749 [details] [review]
Pull Request

Super nice. And I cannot cheer enough about the removal of a dependency, especially from ThirdParty.

I would normally ask you to update the UITests (ReaderViewUITests) to reflect these changes in functionality (swipe left to reveal Mark As Read instead of swipe right) but seeing as those tests are broken because the accessibility label is an attributed string and Kif can't perform actions on those, then there doesn't seem much point. 

If you feel the need, you _could_ reimplement ReaderViewUITests in UITesting in a new target and actually get them to work, but don't feel obliged.

Comment 6

[Farhan Patel [:farhan]]

master f8c4e23633989fb79c62f174b21e8d3182779a7a