Closed
Bug 1237627
Opened 8 years ago
Closed 6 years ago
Improve the wording of the FileDiff review button
Categories
(MozReview Graveyard :: General, defect)
MozReview Graveyard
General
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: ato, Unassigned)
Details
Attachments
(1 file)
|
95.00 KB,
image/png
|
Details |
Screen Shot 2016-01-07 at 15.04.10.png
Following the upgrade to Review Board 2.5.2, there is a new “Not Reviewed” button (although it’s not really clear it’s a button) that isn’t changed to “Reviewed” when the reviewer has reviewed the patch. It is also possible for the patch author to change the button to reviewed, but I don’t think it’s the intention that people who are not marked as reviewers should be able to change the review status.
|
Reporter | |
Comment 1•8 years ago
|
||
The the attached screenshot.
|
||
Comment 2•8 years ago
|
||
The problem here seems to be that the wording of that button is confusing. We should make it clear that there's no shared state between this and the ship-it button.
|
|
||
Updated•8 years ago
|
Summary: “Not Reviewed” not marked reviewed when patch is reviewed → Improve the wording of the FileDiff review button
|
Assignee | |
Updated•8 years ago
|
Product: Developer Services → MozReview
|
||
Comment 3•6 years ago
|
||
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•