Closed
Bug 1237678
Opened 8 years ago
Closed 8 years ago
Update in-tree version of compare-locales
Categories
(Localization Infrastructure and Tools :: compare-locales, defect)
Localization Infrastructure and Tools
compare-locales
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Assigned: Pike)
References
Details
Attachments
(1 file, 4 obsolete files)
8.21 KB,
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
We want a new release of compare-locales, let's make sure we do one we want in mozilla-central.
Assignee | ||
Comment 1•8 years ago
|
||
Matjaz, do you want to review this on the python/l10n side? When we did the initial import, folks were fine with compare-locales updates landing with our review.
Assignee | ||
Comment 2•8 years ago
|
||
This corresponds to https://github.com/Pike/compare-locales/compare/873e557...2f34879, btw.
Comment 3•8 years ago
|
||
Comment on attachment 8705253 [details] [diff] [review] update to 1.0, which isn't really released yet It took me some time to grasp the code, but now it makes sense. I would probably use slightly different style (e.g. .format() vs. %), but that's a subjective opinion and less important than keeping the code style consistent. Nit: would testKnownButOutOfContext() be a better name than testKnownButWrong()? Wrong seems too general and implies it's going to throw an error (or warning). Btw, should this patch actually by attached to bug 1222510? Note: I did NOT run the code.
Attachment #8705253 -
Flags: review?(m) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/30153/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/30153/
Attachment #8705705 -
Flags: review?(rail)
Assignee | ||
Comment 5•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/30155/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/30155/
Attachment #8705706 -
Flags: review?(rail)
Assignee | ||
Comment 6•8 years ago
|
||
Also fix that the default merge dir in the mach command creates a directory that's the merge make target, and thus keeps that make target from actually running. Review commit: https://reviewboard.mozilla.org/r/30157/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/30157/
Attachment #8705707 -
Flags: review?(gps)
Assignee | ||
Comment 7•8 years ago
|
||
https://reviewboard.mozilla.org/r/30153/#review26849 Wrong bug.
Assignee | ||
Updated•8 years ago
|
Attachment #8705705 -
Attachment is obsolete: true
Attachment #8705705 -
Flags: review?(rail)
Assignee | ||
Updated•8 years ago
|
Attachment #8705706 -
Attachment is obsolete: true
Attachment #8705706 -
Flags: review?(rail)
Assignee | ||
Updated•8 years ago
|
Attachment #8705707 -
Attachment is obsolete: true
Attachment #8705707 -
Flags: review?(gps)
Assignee | ||
Comment 8•8 years ago
|
||
This updates to the 1.0 version that's on pypi now, with a follow-up for Matjaz's comment addressed.
Attachment #8705253 -
Attachment is obsolete: true
Attachment #8706010 -
Flags: review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/57068346a23b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•