Closed Bug 1237678 Opened 5 years ago Closed 5 years ago

Update in-tree version of compare-locales

Categories

(Localization Infrastructure and Tools :: compare-locales, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Pike, Assigned: Pike)

References

Details

Attachments

(1 file, 4 obsolete files)

We want a new release of compare-locales, let's make sure we do one we want in mozilla-central.
Matjaz, do you want to review this on the python/l10n side?

When we did the initial import, folks were fine with compare-locales updates landing with our review.
Assignee: nobody → l10n
Status: NEW → ASSIGNED
Attachment #8705253 - Flags: review?(m)
Comment on attachment 8705253 [details] [diff] [review]
update to 1.0, which isn't really released yet

It took me some time to grasp the code, but now it makes sense. I would probably use slightly different style (e.g. .format() vs. %), but that's a subjective opinion and less important than keeping the code style consistent.

Nit: would testKnownButOutOfContext() be a better name than testKnownButWrong()? Wrong seems too general and implies it's going to throw an error (or warning).

Btw, should this patch actually by attached to bug 1222510?

Note: I did NOT run the code.
Attachment #8705253 - Flags: review?(m) → review+
Also fix that the default merge dir in the mach command creates a directory
that's the merge make target, and thus keeps that make target from actually
running.

Review commit: https://reviewboard.mozilla.org/r/30157/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30157/
Attachment #8705707 - Flags: review?(gps)
Attachment #8705705 - Attachment is obsolete: true
Attachment #8705705 - Flags: review?(rail)
Attachment #8705706 - Attachment is obsolete: true
Attachment #8705706 - Flags: review?(rail)
Attachment #8705707 - Attachment is obsolete: true
Attachment #8705707 - Flags: review?(gps)
This updates to the 1.0 version that's on pypi now, with a follow-up for Matjaz's comment addressed.
Attachment #8705253 - Attachment is obsolete: true
Attachment #8706010 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/57068346a23b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.