1237714 - nsContentUtils::IsCustomElementName is slower than it should be

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It's doing 2 checks like so:

2779   if (NS_FAILED(nsContentUtils::CheckQName(str, false, &colon)) || colon ||
2780       str.FindChar('-') == -1) {
2781     return false;

but in practice the CheckQName() call will always return success, there will almost never be a colon and there will almost never be a '-'.  So why aren't we checking for the '-' first and skipping the expensive CheckQName call in the common case of there being no '-'?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Make nsContentUtils::IsCustomElementName faster in the common case of a non-custom-element name

Comment 2

[Boris Zbarsky [:bzbarsky]]

I did check that this makes IsCustomElementName almost disappear from my profile in bug 1232023.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8fc13f4bc59e

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8fc13f4bc59e