If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

mach taskcluster-graph JSON output should be more deterministic and easier to read

RESOLVED FIXED

Status

Taskcluster
Integration
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Patches forthcoming.
(Assignee)

Comment 1

2 years ago
Created attachment 8705305 [details]
MozReview Request: Bug 1237739 - Sort keys in generated graph; r?garndt

Deterministic output is easier to read and test. We're not fully
deterministic with this patch, but it's a start.

Review commit: https://reviewboard.mozilla.org/r/29919/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29919/
Attachment #8705305 - Flags: review?(garndt)
(Assignee)

Comment 2

2 years ago
Created attachment 8705306 [details]
MozReview Request: Bug 1237739 - Use set and sort graph scopes; r?garndt

We're already casting the list of scopes to a set later. So we might as
well use a set from the beginning.

While we're here, sort the final value so output is more deterministic
and easier to read. This sort shouldn't matter since the existing set()
would have lost ordering.

Review commit: https://reviewboard.mozilla.org/r/29921/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29921/
Attachment #8705306 - Flags: review?(garndt)

Updated

2 years ago
Attachment #8705305 - Flags: review?(garndt) → review+

Comment 3

2 years ago
Comment on attachment 8705305 [details]
MozReview Request: Bug 1237739 - Sort keys in generated graph; r?garndt

https://reviewboard.mozilla.org/r/29919/#review26755

Comment 4

2 years ago
Comment on attachment 8705306 [details]
MozReview Request: Bug 1237739 - Use set and sort graph scopes; r?garndt

https://reviewboard.mozilla.org/r/29921/#review26757
Attachment #8705306 - Flags: review?(garndt) → review+

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a927febe3cf8
https://hg.mozilla.org/integration/mozilla-inbound/rev/f95c58b050b0

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a927febe3cf8
https://hg.mozilla.org/mozilla-central/rev/f95c58b050b0
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.