1237739 - mach taskcluster-graph JSON output should be more deterministic and easier to read

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Gregory Szorc [:gps]]

Patches forthcoming.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1237739 - Sort keys in generated graph; r?garndt

Deterministic output is easier to read and test. We're not fully
deterministic with this patch, but it's a start.

Review commit: https://reviewboard.mozilla.org/r/29919/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29919/

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1237739 - Use set and sort graph scopes; r?garndt

We're already casting the list of scopes to a set later. So we might as
well use a set from the beginning.

While we're here, sort the final value so output is more deterministic
and easier to read. This sort shouldn't matter since the existing set()
would have lost ordering.

Review commit: https://reviewboard.mozilla.org/r/29921/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29921/

Comment 3

[Greg Arndt [:garndt]]

Comment on attachment 8705305 [details]
MozReview Request: Bug 1237739 - Sort keys in generated graph; r?garndt

https://reviewboard.mozilla.org/r/29919/#review26755

Comment 4

[Greg Arndt [:garndt]]

Comment on attachment 8705306 [details]
MozReview Request: Bug 1237739 - Use set and sort graph scopes; r?garndt

https://reviewboard.mozilla.org/r/29921/#review26757

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a927febe3cf8
https://hg.mozilla.org/integration/mozilla-inbound/rev/f95c58b050b0

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a927febe3cf8
https://hg.mozilla.org/mozilla-central/rev/f95c58b050b0