Closed Bug 1237739 Opened 5 years ago Closed 5 years ago

mach taskcluster-graph JSON output should be more deterministic and easier to read

Categories

(Taskcluster :: Services, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gps, Assigned: gps)

Details

Attachments

(2 files)

Patches forthcoming.
Deterministic output is easier to read and test. We're not fully
deterministic with this patch, but it's a start.

Review commit: https://reviewboard.mozilla.org/r/29919/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29919/
Attachment #8705305 - Flags: review?(garndt)
We're already casting the list of scopes to a set later. So we might as
well use a set from the beginning.

While we're here, sort the final value so output is more deterministic
and easier to read. This sort shouldn't matter since the existing set()
would have lost ordering.

Review commit: https://reviewboard.mozilla.org/r/29921/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29921/
Attachment #8705306 - Flags: review?(garndt)
Attachment #8705305 - Flags: review?(garndt) → review+
Comment on attachment 8705305 [details]
MozReview Request: Bug 1237739 - Sort keys in generated graph; r?garndt

https://reviewboard.mozilla.org/r/29919/#review26755
Comment on attachment 8705306 [details]
MozReview Request: Bug 1237739 - Use set and sort graph scopes; r?garndt

https://reviewboard.mozilla.org/r/29921/#review26757
Attachment #8705306 - Flags: review?(garndt) → review+
https://hg.mozilla.org/mozilla-central/rev/a927febe3cf8
https://hg.mozilla.org/mozilla-central/rev/f95c58b050b0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Component: Integration → Services
You need to log in before you can comment on or make changes to this bug.