1237781 - Some files get rebuilt when unmodified because parent directory gets modified

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Ed Lee :Mardak]

I was modifying add-on/panel/js/panel.jsx and `make build` correctly builds built/add-on/chrome/content/panels/js/panel.js but the rule for add-on: results in RSYNC updating the modification time of built/add-on/chrome/content/panels/js directory. This then causes the following build to rebuild all jsx files in that directory because:

$(BUILT)/add-on/chrome/content/panels/js/%.js: add-on/panels/js/%.jsx $(BUILT)/add-on/chrome/content/panels/js

My add-on/panel/js directory was getting an updated timestamp because vi creates/deletes temporary files in that directory when editing/saving.

We can avoid this by removing the makefile dependency on $(BUILT)/add-on/chrome/content/panels/js

Comment 1

[Ed Lee :Mardak]

And as a reference but we probably won't do it as it makes the Makefile harder to maintain:

https://lists.gnu.org/archive/html/help-gnu-utils/2007-08/msg00018.html

Comment 2

[GitHub Autolander Bot]

Attachment: [loop] dmose:rebuild-1237781 > mozilla:master

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Link to Github pull-request: https://github.com/mozilla/loop/pull/57

Comment 4

[Ed Lee :Mardak]

Comment on attachment 8705360 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop/pull/57

r=Mardak with adding @ for `@mkdir`s

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

https://github.com/mozilla/loop/commit/6da527f116e7b20d12a23e91824d2be539006e15