Some files get rebuilt when unmodified because parent directory gets modified

RESOLVED FIXED

Status

Hello (Loop)
Client
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Mardak, Assigned: dmose)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
I was modifying add-on/panel/js/panel.jsx and `make build` correctly builds built/add-on/chrome/content/panels/js/panel.js but the rule for add-on: results in RSYNC updating the modification time of built/add-on/chrome/content/panels/js directory. This then causes the following build to rebuild all jsx files in that directory because:

$(BUILT)/add-on/chrome/content/panels/js/%.js: add-on/panels/js/%.jsx $(BUILT)/add-on/chrome/content/panels/js

My add-on/panel/js directory was getting an updated timestamp because vi creates/deletes temporary files in that directory when editing/saving.

We can avoid this by removing the makefile dependency on $(BUILT)/add-on/chrome/content/panels/js
(Reporter)

Comment 1

2 years ago
And as a reference but we probably won't do it as it makes the Makefile harder to maintain:

https://lists.gnu.org/archive/html/help-gnu-utils/2007-08/msg00018.html
Created attachment 8705359 [details] [review]
[loop] dmose:rebuild-1237781 > mozilla:master
(Assignee)

Comment 3

2 years ago
Created attachment 8705360 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop/pull/57
Attachment #8705360 - Flags: review?(edilee)
Attachment #8705360 - Flags: review?(dcritchley)
Attachment #8705360 - Flags: review?(crafuse)
(Reporter)

Comment 4

2 years ago
Comment on attachment 8705360 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop/pull/57

r=Mardak with adding @ for `@mkdir`s
Attachment #8705360 - Flags: review?(edilee)
Attachment #8705360 - Flags: review?(dcritchley)
Attachment #8705360 - Flags: review?(crafuse)
Attachment #8705360 - Flags: review+
(Assignee)

Comment 5

2 years ago
https://github.com/mozilla/loop/commit/6da527f116e7b20d12a23e91824d2be539006e15
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Reporter)

Updated

2 years ago
Iteration: --- → 46.1 - Dec 28
You need to log in before you can comment on or make changes to this bug.