Include asyncCaller when iterating rejection frames

NEW
Unassigned

Status

()

Toolkit
Async Tooling
2 years ago
11 months ago

People

(Reporter: jryans, Unassigned)

Tracking

43 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Some parts of our code now join two sides of an async operation into one stack with things like Cu.callFunctionWithAsyncStack.

By checking the `asyncCaller` part of a stack, we can continue across the async barrier when reporting rejection stacks.
(Reporter)

Comment 1

2 years ago
Created attachment 8705381 [details]
MozReview Request: Bug 1237808 - Include asyncCaller when iterating rejection frames. r=Yoric

Review commit: https://reviewboard.mozilla.org/r/29953/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29953/
Attachment #8705381 - Flags: review?(dteller)
Comment on attachment 8705381 [details]
MozReview Request: Bug 1237808 - Include asyncCaller when iterating rejection frames. r=Yoric

https://reviewboard.mozilla.org/r/29953/#review26819

::: toolkit/modules/Promise-backend.js:197
(Diff revision 1)
> -            stack = stack.caller;
> +            stack = stack.asyncCaller || stack.caller;

Mmmmh.... Is it really `asyncCaller` when we're trying to remove top frames?

It would be great if you had a test for that.
Attachment #8705381 - Flags: review?(dteller)
(Reporter)

Updated

11 months ago
Assignee: jryans → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.