Closed Bug 1237879 Opened 4 years ago Closed 4 years ago

Add missing NSIS paths to python scripts

Categories

(Release Engineering :: General, defect)

defect
Not set

Tracking

(firefox45+ fixed, firefox46 fixed)

RESOLVED FIXED
Tracking Status
firefox45 + fixed
firefox46 --- fixed

People

(Reporter: rstrong, Assigned: rstrong)

References

Details

Attachments

(1 file, 1 obsolete file)

This patch makes the python scripts consistent. Currently our 64 bit Windows builds are using an older version of NSIS than our 32 bit builds. This is also blocking the configure.in changes in bug 1237040 which are needed to deploy a new version of NSIS.
Attached patch patch rev1 (obsolete) — Splinter Review
Try push
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c323fc5476f3

I verified the builds use the correct version of NSIS whereas before it was using an earlier version.
Attachment #8705462 - Flags: review?(bhearsum)
So, if these are only used with the branch they are checked in to then I can also remove the following
C:/mozilla-build/nsis-2.46u;

Just let me know.
Comment on attachment 8705462 [details] [diff] [review]
patch rev1

Review of attachment 8705462 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #3)
> So, if these are only used with the branch they are checked in to then I can
> also remove the following
> C:/mozilla-build/nsis-2.46u;
> 
> Just let me know.

Yeah, that should be safe. r=me either way.
Attachment #8705462 - Flags: review?(bhearsum) → review+
Carrying forward r+
Attachment #8705462 - Attachment is obsolete: true
Attachment #8705648 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/4cd39502e3d6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Comment on attachment 8705648 [details] [diff] [review]
patch with NSIS 2.46u removed

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: We'd like to get this in esr45 so it has the additional dll pre-loading functionality and so we don't have to support the older versions of NSIS until esr45 is EOL.
[Describe test coverage new/current, TreeHerder]: This has baked on nightly for several days.
[Risks and why]: Improperly configured build systems might break as we have seen but now that the build systems have been fixed I don't expect any additional issues.
[String/UUID change made/needed]: None
Attachment #8705648 - Flags: approval-mozilla-aurora?
[Tracking Requested - why for this release]: See previous comment
Attachment #8705648 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.