Closed
Bug 1237902
Opened 8 years ago
Closed 8 years ago
Moz2Dify DrawTableBorderSegment()
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(3 files)
3.79 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
27.62 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
2.43 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
This one's pretty easy.
Assignee | ||
Comment 1•8 years ago
|
||
We change the color and anti-aliasing on the gfxContext but never do anything with it while those values are changed.
Attachment #8705475 -
Flags: review?(roc)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
And to several functions above it in the callgraph, ones that no longer need an nsRenderingContext.
Attachment #8705477 -
Flags: review?(roc)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8705479 -
Flags: review?(roc)
Attachment #8705475 -
Flags: review?(roc) → review+
Attachment #8705477 -
Flags: review?(roc) → review+
Attachment #8705479 -
Flags: review?(roc) → review+
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/957569c6b178028826c1dc13d11895152d020287 Bug 1237902 (part 1) - Remove unneeded gfxContext ops in DrawTableBorderSegment(). r=roc. https://hg.mozilla.org/integration/mozilla-inbound/rev/4538baf122990a4d8efd2e98b22a0c9929cdcf90 Bug 1237902 (part 2) - Pass a DrawTarget to DrawTableBorderSegment(). r=roc. https://hg.mozilla.org/integration/mozilla-inbound/rev/6c88738fdc4d8bea3f88969e89b0c04b2603b9e5 Bug 1237902 (part 3) - Change the gfxContextMatrixAutoSaveRestore in PaintTableBorderBackground() to an AutoRestoreTransform. r=roc.
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/957569c6b178 https://hg.mozilla.org/mozilla-central/rev/4538baf12299 https://hg.mozilla.org/mozilla-central/rev/6c88738fdc4d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•