Closed Bug 123791 Opened 23 years ago Closed 23 years ago

Installing Shockwave crashes Mozilla

Categories

(Core Graveyard :: Plug-ins, defect)

x86
Windows 2000
defect
Not set
blocker

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mseaborn, Assigned: srgchrpv)

References

Details

(Keywords: crash, regression)

Attachments

(2 files)

From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.8+) Gecko/20020205 BuildID: 2002020512 When attempting to install the shockwave plug-in the Mozilla crashed. Debugging in Visual C++ reports Unresolved Exception in mozilla.exe (NTDLL.DLL) 0xC0000005: Access Violation Reproducible: Always Steps to Reproduce: 1. Obtain Shockwave installer for Netscape 2. Run through install (select US English) 3. When Mozilla starts up and goes to the shockwave completion page the browser will crash Actual Results: Browser crashed Expected Results: Completion of Shockwave installation
Same here.
Yes, this is a regression on the trunk. works on 0204 , but not on 0205 or 0206. caused due to bug 123005 ? adding keywords, bumping up severity
Severity: critical → blocker
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: edt0.9.4, regression
Does this occir on 094?
networks is slow right now.will try the 0.9.4 branch once I connect to external sites. stack: nsPluginStreamInfo::SetURL [d:\builds\seamonkey\mozilla\modules\plugin\base\src\nsPluginHostImpl.cpp, line 1467] nsPluginStreamListenerPeer::OnDataAvailable [d:\builds\seamonkey\mozilla\modules\plugin\base\src\nsPluginHostImpl.cpp, line 2068] nsStreamListenerTee::OnDataAvailable [d:\builds\seamonkey\mozilla\netwerk\base\src\nsStreamListenerTee.cpp, line 57] nsHttpChannel::OnDataAvailable [d:\builds\seamonkey\mozilla\netwerk\protocol\http\src\nsHttpChannel.cpp, line 2499] nsOnDataAvailableEvent::HandleEvent [d:\builds\seamonkey\mozilla\netwerk\base\src\nsStreamListenerProxy.cpp, line 203] PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 591] PL_ProcessPendingEvents [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 524] _md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 1072] USER32.dll + 0x2a64c (0x77e9a64c)
yes, crashes on the branch as well (0205 0.9.4 )
I do not crash with my debug build nor with: http://ftp.mozilla.org/pub/mozilla/nightly/2002-02-05-22-0.9.4ec/embed-win32.zip Steps I took: 1. Ensure Shockwave is in your 4.x plugins folder 2. Remove the Shockwave Windows Registry key under Software/Macromedia 3. Visit http://www.macromedia.com/shockwave/welcome
Brent can you try testing with an embedded client build.
I am seeing this only when you have completely removed shockwave from you machine and try a fresh install. On the embed build I tried from last nite, it did not crash since it was picking up the file form 4.x installation (i guess). Also, the shockwave installer did not directly install into mfc embed...and I could not crash there. however, I crash halfway on 0206 trunk and 0205 0.9.4 branch build consistently on NT, 98.
I can't get this to happen on ANY EC build (tried mozilla installer, embed.zip, and Netscape SetupB.exe blob installer from today). I used the Shockwave installer. Verify your build date is 20010205 in about: I can reproduce on the trunk, but I hang instead of crash. Could be due to removing the old Shockwave hack which is only the trunk. Will investigate when I get a trunk debug tree ready.
Assignee: av → peterl
Peter, my bad:( this is the regression from bug 11530
Assignee: peterl → serge
Keywords: crash, patch
This miscalculation of the buffer length can cause any random crash in the trunk build, the branch build however has the right code to calculate that value, and I cannot reproduce the crash on the branch. Srirang, could you provide TB reports for the branch crashes you were seeing. Thanks.
Comment on attachment 68249 [details] [diff] [review] patch for the tunk (not for 094 branch) r=peterl Way to go Serge!
Attachment #68249 - Flags: review+
Went to http://www.macromedia.com/shockwave/welcome as suggested by Peter using Mozilla. Flash worked fine, Shockwave displayed blank screen and status bar showed 'sending request to pinger.shockwave.com'. Started IE and went to the same page, it opend Shockwave Update Download' window. Once completed I restarted Mozilla and Shockwave worked fine. Attempting to install Shockwave from Netscape installer still fails upon reaching http://www.shockwave.com/download/completion/index.html during installation. However when visting it out of the installation it works fine.
Comment on attachment 68249 [details] [diff] [review] patch for the tunk (not for 094 branch) sr=beard
Attachment #68249 - Flags: superreview+
I am seeing this error on the branch(0206). I could not reproduce the crash today:(. Pls make sure to remove all references to the shockwave plugin from your HD. ( from registry, windows folder, 4.x folder). I got this error just about when the registration dialog should come up and where I can input my name/email etc. The install proceeds jsut fine on my trunk build from 0204 date. So , the question of my HD being empty (2 gb free) and being unwriteable does not arise. After I click OK in this error message and click on " Test Players' link on top right of the page ( download completion page that pops up automatically after browser restart), my browser just freezes. Let me know if you need any other details. Thx
I did try 2002-01-15-22-0.9.4ec w/o fix for bug 115308 and 2002-02-06-23-0.9.4ec the latest one. Both builds behave identically: I have not seen any disk space related dialogs as Shrirang mentioned above. There is no registration dialog. Netscape does *HANG*, I assume, on any page with shockwave content if http://www.shockwave.com/download/completion/index.html is open, at least "Reload" button or "Test Players" link are the examples. However living that page (e.g. clicking on netscape logo or Help->About Plug-ins) and revisiting it again seems to fix the hang. So for the 094 branch there is no regression from fix for bug 115308, but there is some other problem which I'm going to pursue.
094 is closed, removing 094 KW.
Keywords: edt0.9.4edt0.9.4-
*** Bug 122792 has been marked as a duplicate of this bug. ***
fix on the trunk
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
this is fixed...verified on 0222 trunk winNT.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: