1237947 - [tc-gip] Can't connect to a device with `adb logcat`

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Bug 1236947 already landed in master, so I'll go with this follow-up. There we managed to run adb logcat in background. Here's what we get:
> - waiting for device -
> ** Cannot start server on remote host
> error: cannot connect to daemon

Example: https://tools.taskcluster.net/task-inspector/#euKRt7hnTRmIyxIehRjIaQ/0

Comment 1

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Based on the logs in Jenkins[1], the command line in TC [2] to connect to a remote ADB device is correct:
> adb -H HOST -P PORT logcat -v threadtime

I wonder if there's a problem on the proxy side.

[1] http://jenkins1.qa.scl3.mozilla.com/view/Bitbar/job/flame-kk-512.b2g-inbound.tinderbox.ui.brick.bitbar/1896/console
[2] https://dxr.mozilla.org/mozilla-central/rev/d4213241bb796fdfa7a5ad4f1989e97b44474364/testing/taskcluster/tasks/phone_test.yml#60

Comment 2

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

The gaiatest command line does use the ADB host. For instance, to run mozdevice and get the version of the device[1]. So I think we can put aside the network-related issues.

One different thing in Jenkins, though: we first flush the logs, execute the tests and then dump them. This is not a good idea as the logcat is a circular list, so we can loose the first logs if the phone becomes verbose.

This makes me wonder if the bitbar firewall doesn't accept only one connection at the same time on a device. 

[1] https://dxr.mozilla.org/mozilla-central/rev/d4213241bb796fdfa7a5ad4f1989e97b44474364/testing/marionette/client/marionette/runner/base.py#856

Comment 3

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Attachment: [Example] Task definition used in Task Creator

TaskCluster is not always verbose about the bad configuration you might input. Then, here's attached a working example, you can upload to https://tools.taskcluster.net/task-creator/

Before using it, please update these variables:
MANDATORY
* created and deadline: Make sure Task Creator put current timestamps
* payload > artifacts > each of them > expires: Put a date in the future

OPTIONAL
* payload > env: Take a more recent gaia HG commit. You may find them here: https://hg.mozilla.org/integration/gaia-central/shortlog
* scopes and payload > image: make sure tester-device is at the most recent version (https://dxr.mozilla.org/mozilla-central/source/testing/docker/tester-device/VERSION )
* payload > capabilities > devices > phone > build: Take a more recent taskId. You can find it here: https://tools.taskcluster.net/index/artifacts/#gecko.v2.mozilla-central.latest.b2g/gecko.v2.mozilla-central.latest.b2g.flame-kk-eng-opt

Comment 4

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

I found what's the issue. Unlike the Jenkins plugin which set ANDROID_SERIAL[1], the "tester-device" docker image stores the ADB serial in SERIAL_ID[2].

In Jenkins, we won't explicitly call `-s $ANDROID_SERIAL` because that variable is already used if -s is not set[3]. Then, the fix is just to call append `-s $SERIAL_ID` at [4]. See this example[5]


[1] https://github.com/mozilla/testdroid-marionette-plugin/blob/6d4ff2893827981bdea6a310a6352000eba30c23/src/main/java/jenkins/plugins/testdroid/DeviceSessionWrapper.java#L221
[2] https://dxr.mozilla.org/mozilla-central/rev/ad1f85f172b7302bef0fa9780df8e2b962780ac6/testing/docker/tester-device/bin/entrypoint#23
[3] http://wiki.cyanogenmod.org/w/Adb_--help See bottom of the page
[4] https://dxr.mozilla.org/mozilla-central/rev/ad1f85f172b7302bef0fa9780df8e2b962780ac6/testing/taskcluster/tasks/phone_test.yml#63
[5] https://tools.taskcluster.net/task-inspector/#SrvscqAXRou-H04TVbNwLg/0

Comment 5

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Attachment: MozReview Request: Bug 1237947 - [tc-gip] Can't connect to a device with `adb logcat` r=garndt

Review commit: https://reviewboard.mozilla.org/r/30885/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30885/

Comment 6

[Greg Arndt [:garndt]]

Comment on attachment 8707811 [details]
MozReview Request: Bug 1237947 - [tc-gip] Can't connect to a device with `adb logcat` r=garndt

https://reviewboard.mozilla.org/r/30885/#review27677

Comment 7

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

https://hg.mozilla.org/integration/b2g-inbound/rev/f931026f68dd7d1feb3c35bfd289580bc3ed7a51
Bug 1237947 - [tc-gip] Can't connect to a device with `adb logcat` r=garndt

Comment 8

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Logcats are now populated: https://tools.taskcluster.net/task-inspector/#McAZhZx7S96J9ll4S7Hy8A/0

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f931026f68dd