1238036 - Selection menu doesn't show Find in Page if Find in Page bar is focused

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Brian Nicholson (:bnicholson)]

Follow-up issue from bug 1229593.

STR: Select text while the find-in-page bar is already visible and focused. The selected text menu won't have Find in Page as an option.

I think this is because the web view isn't the first responder, so it doesn't get asked which items to show. Steph has some comments in https://github.com/mozilla/firefox-ios/pull/1408.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1431

touchesBegan doesn't get fired for WKWebView, presumably because they don't fire the super UIView.hitTest implementation triggers the touch events. As a workaround, we can hook into hitTest directly.

Comment 2

[Stephan Leroux [:sleroux]]

Comment on attachment 8706596 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1431

Looks like this works. Its kind of a hack considering this isn't what hitTest is meant for but if it gives us a way to perform the responder resignation then so be it. Only thing that this might break is webview interactions if it relies on not being the first responder but the actions I did (navigation, long press)  worked fine.

Comment 3

[Brian Nicholson (:bnicholson)]

https://github.com/mozilla/firefox-ios/commit/f31a5ba6153d754ef90f962d6d133476424a33da