Closed
Bug 1238092
Opened 9 years ago
Closed 9 years ago
Update Mobile Activation snippet template to capture keypress events
Categories
(Snippets Graveyard :: General, defect)
Snippets Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ckprice, Assigned: giorgos)
References
Details
This bug is based on the information in bug1237350comment3.
Snippet template to update: https://snippets.allizom.org/admin/base/snippettemplate/50/
Bug 1237350 is updates to the product code to remove the keypress takeovers, but in the meantime let's see if we can make this modification to the snippet to get out of the door.
For reference:
(In reply to :Gijs Kruitbosch from comment #3)
> Finally, I believe snippets can work around this by adding an event listener
> for the "keypress" event to the textbox and calling event.stopPropagation()
> on the event. That should probably be a separate bug against the snippets,
> though.
:giorgos - would you be available to take care of this in the upcoming week?
Flags: needinfo?(giorgos)
Assignee | ||
Comment 1•9 years ago
|
||
Pull request https://github.com/mozilla/snippets/pull/77
Flags: needinfo?(giorgos)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → giorgos
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
Fix: https://github.com/mozilla/snippets/commit/9f3d68bda0eb2a9c1c023cab6dcaff3b4ef6fbd7
This is now live on production. I'll push the same fix to the snippets service so all future snippets with input boxes get the fix and then I'll revert the changes made here.
I'll keep this bug open to track the removal as well.
Assignee | ||
Updated•9 years ago
|
Summary: Update Mobile Activation snippet template to capture keypress events → Prevent search box from taking keypress events
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Summary: Prevent search box from taking keypress events → Update Mobile Activation snippet template to capture keypress events
Comment 4•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/snippets-service
https://github.com/mozilla/snippets-service/commit/cdc13f87a847ca3869a37beb0569e1b2c164572c
Merge pull request #150 from glogiotatidis/bug1238092-sugardough
[bug 1241124] Prevent search box from stealing keypresses.
Assignee | ||
Comment 5•9 years ago
|
||
Template was updated and we pushed a generic fix as well.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Snippets → Snippets Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•