1238114 - Migrate Fennec bundle ID from debug target for Firefox to Fennec app in iTunes

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Stephan Leroux [:sleroux]]

Now with the Fennec app in iTunes, we'll need to change our 'debug' build bundle ID to something else since that uses 'Fennec'. Probably something like 'firefox.debug'.

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios-build-tools/pull/20

Along with the notes on the PR, I've setup a Fennec app in our iTunes account that we can start building Fennec builds with.

Comment 2

[Emily Toop (:fluffyemily)]

Comment on attachment 8706365 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios-build-tools/pull/20

Let me know once we've got the new app set up on TestFlight and I'll look at updating the fastlane stuff to work with it.

Comment 3

[Stephan Leroux [:sleroux]]

The app has been setup in iTunes named 'Fennec web browser' and uses the same bundle ID we were using for debug (com.mozilla.io.Fennec). I've already gone ahead and generated the distribution provisioning profiles for the app + extensions so I think it should be good to go for the fastlane stuff. Let me know when the fastlane stuff has been updated and I can give it a whirl by using it to build our first 2.0 TF build.

Comment 4

[Stephan Leroux [:sleroux]]

com.mozilla.io.Fennec - > org.mozilla.ios.Fennec

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I hate to ask this, but if we are going to put the app on TestFlight as Firefox Beta, do you think we should use org.mozilla.ios.FirefoxBeta instead?

And leave .Fennec as is and make that the build that developers run locally? (Currently)

Comment 6

[Stephan Leroux [:sleroux]]

Sure that works. I just need to setup the bundle id and generate some profiles which doesn't take long. At least with this patch I only need to change it in one place and it updates across the extensions :)

Comment 7

[Stephan Leroux [:sleroux]]

Another issue that I thought of when we were discussing the various release channels is the potential need for a 3rd app. The problem our TF users are running into is that they are unable to run the 'stable' beta build alongside the production build because they use the same bundle identifier. They would only be able to run Firefox Beta and (production or stable). If we wanted to go with the nightly/stable model we would need:

1. A nightly build from master using the Fennec bundle ID
2. A stable build from the 3.X branch using the FirefoxBeta ID
3. A production build for 3.X using the Firefox ID

This would mean that our TF channel under the current Firefox app becomes obsolete and those users would be transferred to a Firefox Beta app.

Thoughts?

Comment 8

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

How about these three channels:

1. Nightly - Only from our Xcode Server, so not for a general audience. Although we could do Enterprise builds for Mozillians.

2. Stable build, org.mozilla.ios.Firefox - TestFlight Channel for 'the next release' - So less frequent and pretty much to test what we will put on the app store.

3. Beta build, org.mozilla.ios.FirefoxBeta - TestFlight channel for following new features.  - More frequent. Stable'ish, but may contain features that are not completely done, or may not appear in the final build.


1 can be on a CI server.

2. Builds for 2 are made when we have tagged a release. So this gives us some extra bake time of 'the real thing' that we are about to push to the store.

3. Builds are made as soon as something lands. Or at least once a week or so. This is where we want most people to be since it lets us asses improvements in general, wether they land on production builds or not.

Comment 9

[Stephan Leroux [:sleroux]]

I like the idea of Nightly being an enterprise build since that can be automated unlike the TestFlight builds. The downside of enterprise builds is we would restrict nightly builds to LDAP Mozilla employees which is probably fine for now until we have a need to give it to external users. Ideally Nightly would also replace the L10N builds since the localizers have LDAP IIRC.

When the release branch is cut and it's ready to ride the stabilization train, I can see the build being promoted to FirefoxBeta for external users. After the bake time period (6 weeks) we would promote it to release. I don't see the need for the Firefox TestFlight channel though unless we wanted a third bake time but that sounds like an Aurora channel to me that we wanted to avoid. I'd also prefer to use FirefoxBeta as the bake channel since it still allows users to use the live version of Firefox.

I don't know about the idea of 'stable-ish' and building when features are done since that seems kind of random. Ideally when we cut the release branch for beta we should be feature complete and the only things we should be uplifting are fixes. If a feature isn't complete it rides the next train. If you want to use features as they come off the wire they should be on Nightly and unlocked when ready using feature flags.

TL;DR

1. Nightly -> Enterprise LDAP
2. Beta -> N.X (N=Release Version) release branch, bake period (6 weeks?)
3. Firefox -> Production release

Comment 10

[Stephan Leroux [:sleroux]]

Comment on attachment 8706365 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios-build-tools/pull/20

This PR includes all of the project settings clean up work I mentioned in the meeting yesterday. Couple of things:

1. This has been rebased from master so it includes all of the Carthage goodness
2. Our Client scheme is no more. I've replaced it with 'Fennec' to better map to the debug/development nomenclature.

Comment 11

[Emily Toop (:fluffyemily)]

Comment on attachment 8706365 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios-build-tools/pull/20

So much cleaner. Looks awesome.

These all run on simulator just fine from inside Xcode. 

There are export/build problems though.

Archive works, but export won't let me export as an ipa when building with Xcode (running the Fennec scheme)

There are some issues when running using fastlane too. Details can be found in the PR.

Comment 12

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios-build-tools/pull/20

Build tools patch

Comment 13

[Stephan Leroux [:sleroux]]

master a6aa5802e419125d735b424a784b00f3c85c0e3a

Comment 14

[Stephan Leroux [:sleroux]]

build-tools master 6237f8a60ebe7b93c543328dbc84b3de102e50f7