provide [ChromeOnly] getter for unfiltered Response object

RESOLVED FIXED in Firefox 46

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

32 Branch
mozilla46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
In order to support better devtools we need to let chrome code inspect the contents of an opaque response.  Lets expose a [ChromeOnly] getter for the unfiltered inner response object.
(Assignee)

Comment 1

2 years ago
Created attachment 8705826 [details] [diff] [review]
P1 Provide a Response.cloneUnfiltered() method for chrome code to access internal Response state. r=ehsan

Does this work for the Cache API storage inspector code?  I still need to write a test.
Attachment #8705826 - Flags: feedback?(poirot.alex)
Comment on attachment 8705826 [details] [diff] [review]
P1 Provide a Response.cloneUnfiltered() method for chrome code to access internal Response state. r=ehsan

Works perfectly for storage inspector needs!
Attachment #8705826 - Flags: feedback?(poirot.alex) → feedback+
(Assignee)

Comment 3

2 years ago
Created attachment 8706594 [details] [diff] [review]
P2 Test chrome-only Response.cloneUnfiltered(). r=ehsan

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a16752bfda4
Attachment #8706594 - Flags: review?(ehsan)
(Assignee)

Updated

2 years ago
Attachment #8705826 - Flags: review?(ehsan)

Comment 4

2 years ago
Comment on attachment 8705826 [details] [diff] [review]
P1 Provide a Response.cloneUnfiltered() method for chrome code to access internal Response state. r=ehsan

Review of attachment 8705826 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/Response.webidl
@@ +24,5 @@
>  
>    [Throws,
>     NewObject] Response clone();
> +
> +  [ChromeOnly, Throws] Response cloneUnfiltered();

Nit: please add NewObject too.
Attachment #8705826 - Flags: review?(ehsan) → review+

Updated

2 years ago
Attachment #8706594 - Flags: review?(ehsan) → review+

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d0b39a33e042
https://hg.mozilla.org/mozilla-central/rev/b12cc3b2697b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.