1238134 - provide [ChromeOnly] getter for unfiltered Response object

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

In order to support better devtools we need to let chrome code inspect the contents of an opaque response.  Lets expose a [ChromeOnly] getter for the unfiltered inner response object.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P1 Provide a Response.cloneUnfiltered() method for chrome code to access internal Response state. r=ehsan

Does this work for the Cache API storage inspector code?  I still need to write a test.

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 8705826 [details] [diff] [review]
P1 Provide a Response.cloneUnfiltered() method for chrome code to access internal Response state. r=ehsan

Works perfectly for storage inspector needs!

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P2 Test chrome-only Response.cloneUnfiltered(). r=ehsan

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a16752bfda4

Comment 4

[(no longer active)]

Comment on attachment 8705826 [details] [diff] [review]
P1 Provide a Response.cloneUnfiltered() method for chrome code to access internal Response state. r=ehsan

Review of attachment 8705826 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/Response.webidl
@@ +24,5 @@
>  
>    [Throws,
>     NewObject] Response clone();
> +
> +  [ChromeOnly, Throws] Response cloneUnfiltered();

Nit: please add NewObject too.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0b39a33e042
https://hg.mozilla.org/integration/mozilla-inbound/rev/b12cc3b2697b

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d0b39a33e042
https://hg.mozilla.org/mozilla-central/rev/b12cc3b2697b