Closed Bug 1238139 Opened 4 years ago Closed 4 years ago

Show snackbar for completed downloads

Categories

(Firefox for Android :: Download Manager, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- verified

People

(Reporter: sebastian, Assigned: sebastian)

Details

Attachments

(3 files)

Currently we only show a snackbar whenever a download has started. It would be nice to have an in-app visual feedback whenever a download has completed successfully (In addition to that notification we already show).
Attachment #8705829 - Flags: feedback?(alam)
To-do:
* Remove notification if download is opened from snackbar?
* Telemetry for "open" action
Comment on attachment 8705829 [details]
download-succeeded-snackbar.png

Awesome, nice thinking Sebastian ;)
Attachment #8705829 - Flags: feedback?(alam) → feedback+
mfinkle: Should "open" send telemetry? If yes, how should the call look like? :)
Flags: needinfo?(mark.finkle)
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Comment on attachment 8705832 [details]
MozReview Request: Bug 1238139 - Show snackbar for completed downloads. r=ahunt,mcomella

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/30207/diff/1-2/
Attachment #8705832 - Attachment description: MozReview Request: Bug 1238139 - Show snackbar for completed downloads. r? → MozReview Request: Bug 1238139 - Show snackbar for completed downloads. r?ahunt,mcomella
Attachment #8705832 - Flags: review?(michael.l.comella)
Attachment #8705832 - Flags: review?(ahunt)
Comment on attachment 8705832 [details]
MozReview Request: Bug 1238139 - Show snackbar for completed downloads. r=ahunt,mcomella

https://reviewboard.mozilla.org/r/30207/#review27759

Looks good to me!
Attachment #8705832 - Flags: review?(ahunt) → review+
(In reply to Sebastian Kaspari (:sebastian) from comment #5)
> mfinkle: Should "open" send telemetry? If yes, how should the call look
> like? :)

I don't know if we have any UI telemetry in the Download Manager for open and delete. If we wanted to add UI telemetry for the toast/snackbar I think we'd use ("launch.1", "toast", "downloads")
Flags: needinfo?(mark.finkle)
Comment on attachment 8705832 [details]
MozReview Request: Bug 1238139 - Show snackbar for completed downloads. r=ahunt,mcomella

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/30207/diff/2-3/
Comment on attachment 8705832 [details]
MozReview Request: Bug 1238139 - Show snackbar for completed downloads. r=ahunt,mcomella

https://reviewboard.mozilla.org/r/30207/#review28255

::: mobile/android/modules/DownloadNotifications.jsm:91
(Diff revision 3)
> +          label: 'Open',

Shouldn't this be localized?

::: mobile/android/modules/DownloadNotifications.jsm:97
(Diff revision 3)
> +              this.showInAboutDownloads(download);

Slick exception handling. :)
Attachment #8705832 - Flags: review?(michael.l.comella) → review+
https://reviewboard.mozilla.org/r/30207/#review28255

> Shouldn't this be localized?

Woops. That's because this started as a prototype/hack. :)
Comment on attachment 8705832 [details]
MozReview Request: Bug 1238139 - Show snackbar for completed downloads. r=ahunt,mcomella

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/30207/diff/3-4/
Attachment #8705832 - Attachment description: MozReview Request: Bug 1238139 - Show snackbar for completed downloads. r?ahunt,mcomella → MozReview Request: Bug 1238139 - Show snackbar for completed downloads. r=ahunt,mcomella
https://hg.mozilla.org/mozilla-central/rev/16fd23fa0103
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Verified as fixed using:
Device: Nexus 6 (Android 6.0)
Build: Firefox for Android 46.0a1 (20156-01-24)
You need to log in before you can comment on or make changes to this bug.