[Preferences] It's possible to accidentally scroll suggestions list down so that blank line appeared

VERIFIED FIXED in Firefox 48

Status

()

defect
--
trivial
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: arni2033, Assigned: Gijs)

Tracking

({regression})

Trunk
Firefox 48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 wontfix, firefox46 wontfix, firefox47 wontfix, firefox48 verified)

Details

Attachments

(2 attachments)

Reporter

Description

3 years ago
>>>   My Info:   Win7_64, Nightly 46, 32bit, ID 20160107030235
STR:
0. (optional) Open 12 tabs with different bugs. You can skip it if you already have 12 different items in history
1. Open about:preferences#general
2. Click in the field "Home page", delete all text there, press Down key to open suggestions
3. Scroll suggestions list to the end

Result:       A blank unselectable line appears in the end of suggestions list.
Expectations: There should be no blank lines in suggestions popup
 
The mechanism is the same as described in bug 1227734. Workaround:
 to install extension "Stylish" and create the following style (without ">"s)
>   @namespace url(http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul);
>   @-moz-document url-prefix(about:preferences){
>   #browserHomePage tree > treecols { border-bottom-width: 0px !important;}}

Regression range:
> https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5288b15d22de&tochange=f14dcd1c8c0b
It was regressed by bug 1087618 because I see exactly "border-bottom: 1px.." added in the changeset
Jaws, can you help find an assignee for this regression?
Flags: needinfo?(jaws)
I talked with Gijs and he said that he knew the fix.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
Assignee

Comment 4

3 years ago
(all the platform-specific styles have stuff like this:

https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/autocomplete.css#61

and it seems that we're using border-image on the <treecol> for the separators, and this is why ntim moved the border to the <treecols> instead. I'm pretty much just making the corresponding change for the autocomplete tree to hide the border there)
Comment on attachment 8730755 [details]
MozReview Request: Bug 1238181 - hide in-content control border on treecols in autocomplete widgets, r?jaws

https://reviewboard.mozilla.org/r/40137/#review36627
Attachment #8730755 - Flags: review?(jaws) → review+

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2f9b5a3b2a90
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Reproduced this on Firefox nightly according to (2016-01-08)

It's verified on Latest Developer Edition: Build ID (20160624004013),User Agent: Mozilla/5.0 (Windows NT 10.0; rv:49.0) Gecko/20100101 Firefox/49.0

Tested OS: Windows10 32bit
QA Whiteboard: [bugday-20160625]
I have reproduced this bug on Nightly 46.0a1 (2016-01-08) on Ubuntu 16.04 LTS, 64 bit!

The bug's fix is now verified on Latest Beta 48.0b3!

Build ID: 20160623122823
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0

As this bug's fix is verified on Windows 10 (comment 8), I am marking this as verified!
Status: RESOLVED → VERIFIED
QA Whiteboard: [bugday-20160625] → [bugday-20160625][testday-20160624]
You need to log in before you can comment on or make changes to this bug.