1238257 - crash in gfxASurface::CairoStatus in Firefox 44.0b7

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[[:philipp]]

[Tracking Requested - why for this release]:

This bug was filed from the Socorro interface and is 
report bp-e3a4cb3f-1903-493b-b339-058aa2160109.
=============================================================
Crashing Thread (0)
Frame 	Module 	Signature 	Source
0 	xul.dll 	gfxASurface::CairoStatus() 	gfx/thebes/gfxASurface.cpp
1 	xul.dll 	mozilla::layers::TextureClientMemoryDIB::AllocateForSurface(mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits>, mozilla::layers::TextureAllocationFlags) 	gfx/layers/TextureDIB.cpp
2 	xul.dll 	mozilla::layers::TextureClientMemoryDIB::CreateSimilar(mozilla::layers::TextureFlags, mozilla::layers::TextureAllocationFlags) 	gfx/layers/TextureDIB.cpp
3 	xul.dll 	mozilla::layers::ContentClientRemoteBuffer::CreateBackBuffer(mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const&) 	gfx/layers/client/ContentClient.cpp
4 	xul.dll 	mozilla::layers::ContentClientRemoteBuffer::BuildTextureClients(mozilla::gfx::SurfaceFormat, mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const&, unsigned int) 	gfx/layers/client/ContentClient.cpp
5 	xul.dll 	mozilla::layers::ContentClientRemoteBuffer::CreateBuffer(gfxContentType, mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const&, unsigned int, RefPtr<mozilla::gfx::DrawTarget>*, RefPtr<mozilla::gfx::DrawTarget>*) 	gfx/layers/client/ContentClient.cpp
6 	xul.dll 	mozilla::TimelineConsumers::HasConsumer(nsIDocShell*) 	docshell/base/timeline/TimelineConsumers.cpp
7 	xul.dll 	mozilla::layers::ShadowLayerForwarder::Attach(mozilla::layers::CompositableClient*, mozilla::layers::ShadowableLayer*) 	gfx/layers/ipc/ShadowLayers.cpp
8 	xul.dll 	mozilla::layers::ShadowLayerForwarder::Connect(mozilla::layers::CompositableClient*, mozilla::layers::ImageContainer*) 	gfx/layers/ipc/ShadowLayers.cpp
9 	xul.dll 	mozilla::layers::ClientPaintedLayer::RenderLayerWithReadback(mozilla::layers::ReadbackProcessor*) 	gfx/layers/client/ClientPaintedLayer.cpp
10 	xul.dll 	mozilla::layers::ClientContainerLayer::RenderLayer() 	gfx/layers/client/ClientContainerLayer.h
11 	xul.dll 	mozilla::layers::ClientLayer::RenderLayerWithReadback(mozilla::layers::ReadbackProcessor*) 	gfx/layers/client/ClientLayerManager.h
12 	xul.dll 	mozilla::layers::ClientContainerLayer::RenderLayer() 	gfx/layers/client/ClientContainerLayer.h
13 	xul.dll 	mozilla::layers::ClientLayerManager::EndTransactionInternal(void (*)(mozilla::layers::PaintedLayer*, gfxContext*, nsIntRegion const&, nsIntRegion const&, mozilla::layers::DrawRegionClip, nsIntRegion const&, void*), void*, mozilla::layers::LayerManager::EndTransactionFlags) 	gfx/layers/client/ClientLayerManager.cpp
14 	xul.dll 	mozilla::layers::ClientLayerManager::EndTransaction(void (*)(mozilla::layers::PaintedLayer*, gfxContext*, nsIntRegion const&, nsIntRegion const&, mozilla::layers::DrawRegionClip, nsIntRegion const&, void*), void*, mozilla::layers::LayerManager::EndTransactionFlags) 	gfx/layers/client/ClientLayerManager.cpp
15 	xul.dll 	nsDisplayList::PaintRoot(nsDisplayListBuilder*, nsRenderingContext*, unsigned int) 	layout/base/nsDisplayList.cpp
16 	xul.dll 	nsLayoutUtils::PaintFrame(nsRenderingContext*, nsIFrame*, nsRegion const&, unsigned int, unsigned int) 	layout/base/nsLayoutUtils.cpp
17 	xul.dll 	PresShell::Paint(nsView*, nsRegion const&, unsigned int) 	layout/base/nsPresShell.cpp

in early incoming data from 44 beta 7 this bug signature (regressing in this version) is on top of the list with 17% of all crashes. so far it is happening on all versions of windows vista and higher and not contained to a particular gpu vendor.

Comment 1

[u279076]

I suspect https://hg.mozilla.org/releases/mozilla-beta/rev/35655c81d4e6.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

We don't see in aurora or nightly?

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #1)
> I suspect https://hg.mozilla.org/releases/mozilla-beta/rev/35655c81d4e6.

That is bug 1233182.

Comment 4

[[:philipp]]

(In reply to Milan Sreckovic [:milan] from comment #2)
> We don't see in aurora or nightly?

no, pretty much only in 44.0b7, but in large quantities there:
https://crash-stats.mozilla.com/search/?signature=%3DgfxASurface%3A%3ACairoStatus&date=%3E2015-06-01&_facets=signature&_facets=version&_facets=app_notes&_facets=user_comments&_facets=adapter_vendor_id&_facets=platform_pretty_version&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-version

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

Bug 1233182 wasn't actually properly fixed, so I reopened it and this should be fixed what they is properly taken care of.

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

I probably have the "what depends on what" the wrong way, if the fix is going to be in bug 1233182.

Comment 7

[[:philipp]]

after looking at 44.0b8 crash data where this signature has totally ceased, i'm changing the status of this bug to fixed as well. thanks for the swift response milan!

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to philipp from comment #7)
> after looking at 44.0b8 crash data where this signature has totally ceased,
> i'm changing the status of this bug to fixed as well. thanks for the swift
> response milan!

This is awesome!!! :)