Closed
Bug 1238268
Opened 10 years ago
Closed 10 years ago
Use version 1.0 of compare-locales in elmo for diff viewing
Categories
(Webtools Graveyard :: Elmo, defect)
Webtools Graveyard
Elmo
Tracking
(firefox46 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | affected |
People
(Reporter: Pike, Assigned: Pike)
References
Details
Attachments
(1 file)
|
1.61 KB,
patch
|
mathjazz
:
review+
|
Details | Diff | Splinter Review |
Right now, elmo diffs show errors for netErrorApp.dtd like:
dom/chrome/netErrorApp.dtd
ERROR: Unparsed content "
<!-- Un esempio (da Firefox):" at 211-242
ERROR: Unparsed content "-->
" at 1018-1022
+_junk_10_1161-1166
+_junk_9_211-458
Need to pick up the version 1.0 of compare-locales to fix this.
| Assignee | ||
Comment 1•10 years ago
|
||
Update compare-locales across https://github.com/Pike/compare-locales/compare/3e65e6bddb34cd7676be2a56c2e20801c5d0f5d3...274cedcafc031f7db681f5f9bdd75d58459b93c9.
Mostly parser fixes that we want here.
We're taking a big refactoring, and thus need to adjust the import paths and module names. We're not hit by other changes.
Updated•10 years ago
|
Attachment #8706907 -
Flags: review?(m) → review+
Comment 2•10 years ago
|
||
Commit pushed to develop at https://github.com/mozilla/elmo
https://github.com/mozilla/elmo/commit/2dbf720867c12dca1979445e5407c13c93e5ea4c
bug 1238268, update compare-locales, r=mathjazz
This updates compare-locales across
https://github.com/Pike/compare-locales/compare/3e65e6bddb34cd7676be2a56c2e20801c5d0f5d3...274cedcafc031f7db681f5f9bdd75d58459b93c9
We're taking a big refactoring, and thus need to adjust the import paths
and module names. We're not hit by other changes.
Reason for this update are mostly parser fixes.
| Assignee | ||
Comment 3•10 years ago
|
||
Landed, and deployed on prod. Dev is still on a different branch.
Aurora diffs look much more like it, now.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•