Remove unneeded stylesheet links in XUL files

RESOLVED FIXED in 4.8

Status

Calendar
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
While working with DOMi I see always rules applied multiple times. For example the .plain rule is applied 5 times with Lightning enabled. Without Lightning it's only 2 times (I don't know yet why 2 times but I want to reduce it also to 1 time in a TB bug).

I see <?xml-stylesheet type="text/css" href="chrome://global/skin/global.css"?> applied in multiple XUL files also when they aren't really needed because this files are running in a messenger window which has already linked to global.css.

I don't know if this removal would speed up things but I can imagine this is using lesser memory.
(Assignee)

Comment 1

2 years ago
Created attachment 8706031 [details] [diff] [review]
noStylesheet.patch

I checked the rules with this elements:
chrome://global/skin/global.css -> .plain in tree
chrome://calendar/content/calendar-view-bindings.css -> calendar-list-tree
chrome://calendar/skin/widgets/calendar-widgets.css -> treenode-checkbox
chrome://calendar/skin/today-pane.css -> #today-pane-panel
chrome://calendar-common/skin/widgets/minimonth.css -> minimonth

I removed the links from files which don't have a direct connection to the link. Like in messenger-overlay-sidebar.xul I removed almost all links and let them for example in today-pane.xul the link to today.css.

I also saw lightning-standalone.xul is never used and removed it. This was added in bug 293563 which was WONTFIXed later.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8706031 - Flags: review?(philipp)
Attachment #8706031 - Flags: review?(philipp) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 2

2 years ago
https://hg.mozilla.org/comm-central/rev/9df83b8b00ed0ac0fafa430041254f9eb8282a07
Bug 1238289 - Remove unneeded stylesheet links in XUL files. r=Fallen

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.8
(Assignee)

Updated

2 years ago
Depends on: 1239434
You need to log in before you can comment on or make changes to this bug.