Closed
Bug 1238404
Opened 8 years ago
Closed 8 years ago
Remove duplicate Dispatch impl in subclasses of nsIEventTarget
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
Details
Attachments
(1 file)
We can use 'using' directive to pull the function from nsIEventTarget.
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/30257/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/30257/
Attachment #8706178 -
Flags: review?(nfroyd)
|
|
Assignee | |
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b51cabec4e2
|
||
Updated•8 years ago
|
Attachment #8706178 -
Flags: review?(nfroyd) → review+
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8706178 [details] MozReview Request: Bug 1238404 - Use 'using' directive instead of having separate Dispatch impl in subclasses of nsIEventTarget. r?froydnj https://reviewboard.mozilla.org/r/30257/#review27055 Ah, this is a much better solution. Thank you!
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/05b4771bed8f59c6521be22718f0d7cfd0cd06c4 Bug 1238404 - Use 'using' directive instead of having separate Dispatch impl in subclasses of nsIEventTarget. r=froydnj
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/05b4771bed8f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•