Closed Bug 1238405 Opened 4 years ago Closed 4 years ago

Missing css style for timepickers in Event Dialog

Categories

(Calendar :: Dialogs, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bv1578, Assigned: Paenglab)

References

Details

Attachments

(1 file, 1 obsolete file)

On trunk the timepickers in the Event Dialog work normally but the popup that appears shows only the numbers for hours and minutes on a white background without any css style about colors, borders, hovering, selected elements etc.

In the datepicker that allows to set the until date, the "Forever" option has a wrong background color (it misses the css style from the datetimepickers.css file).
Not sure about this, but maybe could it be related to Bug 1230991?
Attached patch datetimepicker.patch (obsolete) — Splinter Review
Sorry, I set the link to datetimepickers.css wrong.

This patch needs to go to aurora as bug 1230991 is now in aurora.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8706288 - Flags: review?(bv1578)
Attachment #8706288 - Flags: approval-calendar-aurora?(philipp)
Comment on attachment 8706288 [details] [diff] [review]
datetimepicker.patch

Review of attachment 8706288 [details] [diff] [review]:
-----------------------------------------------------------------

The until-datepicker still misses the style in the "forever" options. It seems that the same link correction is required on the line 1532.
Attachment #8706288 - Flags: review?(bv1578) → review-
OS: Windows 7 → All
Hardware: x86 → All
Not so good when I'm doing such things at work between phone calls. :(
Attachment #8706288 - Attachment is obsolete: true
Attachment #8706288 - Flags: approval-calendar-aurora?(philipp)
Attachment #8706312 - Flags: review?(bv1578)
Attachment #8706312 - Flags: approval-calendar-aurora?(philipp)
Comment on attachment 8706312 [details] [diff] [review]
datetimepicker.patch

Review of attachment 8706312 [details] [diff] [review]:
-----------------------------------------------------------------

Sometimes it's worse at home when wives scream and kids cry. ;)
Attachment #8706312 - Flags: review?(bv1578) → review+
Attachment #8706312 - Flags: approval-calendar-aurora?(philipp) → approval-calendar-aurora+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.8
Backported to releases/comm-aurora changeset 1c4e397973ec
Target Milestone: 4.8 → 4.7
Blocks: 1230991
You need to log in before you can comment on or make changes to this bug.