Missing css style for timepickers in Event Dialog

RESOLVED FIXED in 4.7

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bv1578, Assigned: Paenglab)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
On trunk the timepickers in the Event Dialog work normally but the popup that appears shows only the numbers for hours and minutes on a white background without any css style about colors, borders, hovering, selected elements etc.

In the datepicker that allows to set the until date, the "Forever" option has a wrong background color (it misses the css style from the datetimepickers.css file).
(Reporter)

Comment 1

3 years ago
Not sure about this, but maybe could it be related to Bug 1230991?
(Assignee)

Comment 2

3 years ago
Created attachment 8706288 [details] [diff] [review]
datetimepicker.patch

Sorry, I set the link to datetimepickers.css wrong.

This patch needs to go to aurora as bug 1230991 is now in aurora.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8706288 - Flags: review?(bv1578)
Attachment #8706288 - Flags: approval-calendar-aurora?(philipp)
(Reporter)

Comment 3

3 years ago
Comment on attachment 8706288 [details] [diff] [review]
datetimepicker.patch

Review of attachment 8706288 [details] [diff] [review]:
-----------------------------------------------------------------

The until-datepicker still misses the style in the "forever" options. It seems that the same link correction is required on the line 1532.
Attachment #8706288 - Flags: review?(bv1578) → review-
(Reporter)

Updated

3 years ago
OS: Windows 7 → All
Hardware: x86 → All
(Assignee)

Comment 4

3 years ago
Created attachment 8706312 [details] [diff] [review]
datetimepicker.patch

Not so good when I'm doing such things at work between phone calls. :(
Attachment #8706288 - Attachment is obsolete: true
Attachment #8706288 - Flags: approval-calendar-aurora?(philipp)
Attachment #8706312 - Flags: review?(bv1578)
Attachment #8706312 - Flags: approval-calendar-aurora?(philipp)
(Reporter)

Comment 5

3 years ago
Comment on attachment 8706312 [details] [diff] [review]
datetimepicker.patch

Review of attachment 8706312 [details] [diff] [review]:
-----------------------------------------------------------------

Sometimes it's worse at home when wives scream and kids cry. ;)
Attachment #8706312 - Flags: review?(bv1578) → review+
Attachment #8706312 - Flags: approval-calendar-aurora?(philipp) → approval-calendar-aurora+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.8
Backported to releases/comm-aurora changeset 1c4e397973ec
Target Milestone: 4.8 → 4.7
Blocks: 1230991
You need to log in before you can comment on or make changes to this bug.