1238405 - Missing css style for timepickers in Event Dialog

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Decathlon]

On trunk the timepickers in the Event Dialog work normally but the popup that appears shows only the numbers for hours and minutes on a white background without any css style about colors, borders, hovering, selected elements etc.

In the datepicker that allows to set the until date, the "Forever" option has a wrong background color (it misses the css style from the datetimepickers.css file).

Comment 1

[Decathlon]

Not sure about this, but maybe could it be related to Bug 1230991?

Comment 2

[Richard Marti (:Paenglab)]

Attachment: datetimepicker.patch

Sorry, I set the link to datetimepickers.css wrong.

This patch needs to go to aurora as bug 1230991 is now in aurora.

Comment 3

[Decathlon]

Comment on attachment 8706288 [details] [diff] [review]
datetimepicker.patch

Review of attachment 8706288 [details] [diff] [review]:
-----------------------------------------------------------------

The until-datepicker still misses the style in the "forever" options. It seems that the same link correction is required on the line 1532.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: datetimepicker.patch

Not so good when I'm doing such things at work between phone calls. :(

Comment 5

[Decathlon]

Comment on attachment 8706312 [details] [diff] [review]
datetimepicker.patch

Review of attachment 8706312 [details] [diff] [review]:
-----------------------------------------------------------------

Sometimes it's worse at home when wives scream and kids cry. ;)

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/12930429db6715cf9f3fbc766370826643fcfb53
Bug 1238405 - Fix the link to datetimepickers.css. r=Decathlon

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Backported to releases/comm-aurora changeset 1c4e397973ec