Closed
Bug 1238424
Opened 8 years ago
Closed 8 years ago
Fix compilation errors on B2G when implementing a new interface for DOM
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: boris, Assigned: boris)
References
Details
Attachments
(1 file)
1007 bytes,
patch
|
brsun
:
review+
|
Details | Diff | Splinter Review |
Here are the errors on the B2G emulator try server: /home/worker/objdir-gecko/objdir/dist/include/mozilla/dom/bluetooth/BluetoothPbapRequestHandle.h:22:1: error: 'BEGIN_BLUETOOTH_NAMESPACE' does not name a type /home/worker/objdir-gecko/objdir/dist/include/mozilla/dom/bluetooth/BluetoothPbapRequestHandle.h:60:1: error: 'END_BLUETOOTH_NAMESPACE' does not name a type /home/worker/objdir-gecko/objdir/dist/include/mozilla/dom/BluetoothVCardPullingEventBinding.h:39:10: error: 'bluetooth' is not a member of 'mozilla::dom' /home/worker/objdir-gecko/objdir/dist/include/mozilla/dom/BluetoothVCardPullingEventBinding.h:39:10: error: 'bluetooth' is not a member of 'mozilla::dom' /home/worker/objdir-gecko/objdir/dist/include/mozilla/dom/BluetoothVCardPullingEventBinding.h:39:61: error: template argument 1 is invalid /home/worker/objdir-gecko/objdir/dist/include/mozilla/dom/BluetoothVCardPullingEventBinding.h:93:11: error: 'BluetoothVCardPullingEvent' in namespace 'mozilla::dom' does not name a type /home/worker/objdir-gecko/objdir/dist/include/mozilla/dom/BluetoothVCardPullingEventBinding.h:114:38: error: 'mozilla::dom::BluetoothVCardPullingEvent' has not been declared /home/worker/objdir-gecko/objdir/dist/include/mozilla/dom/BluetoothVCardPullingEvent.h:35:10: error: 'bluetooth' was not declared in this scope /home/worker/objdir-gecko/objdir/dist/include/mozilla/dom/BluetoothVCardPullingEvent.h:35:47: error: template argument 1 is invalid /home/worker/objdir-gecko/objdir/dist/include/mozilla/dom/BluetoothVCardPullingEvent.h:52:3: error: 'bluetooth' does not name a type
Assignee | ||
Comment 1•8 years ago
|
||
Reference try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf99b79ba13c&selectedJob=15255047
Assignee | ||
Comment 2•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8706192 -
Flags: review?(brsun)
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=908d2968a191
Comment 4•8 years ago
|
||
Comment on attachment 8706192 [details] [diff] [review] Fix a missing header in Bluetooth module Review of attachment 8706192 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for catching this bug and solving it.
Attachment #8706192 -
Flags: review?(brsun) → review+
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5737b0164ca5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•