|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
Some of the necko GeckoSimplePrograms, while still compile, haven't been run in a long time. We should either convert them to CppUnitTests, or remove them.
Created attachment 8706317 [details] MozReview Request: Bug 1238507 - Convert necko test binaries to cppunittests r?mcmanus - TestServ now includes code copied over from TestStreamLoader, to test the server unattended - Tests may still take optional command line arguments, if we wish to run them manually Review commit: https://reviewboard.mozilla.org/r/30313/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/30313/
Valentin, don't forget we also have gtests. Might be worth considering to convert rather to those.
Comment on attachment 8706317 [details] MozReview Request: Bug 1238507 - Convert necko test binaries to cppunittests r?mcmanus https://reviewboard.mozilla.org/r/30313/#review27025 try is busted r- honza's comment is valid - I would also add that you should feel free to delete tests that aren't being run and don't have any value in your judgment. but I'll take this (updated) patch because I'll always take incremental progress. thanks!
The patch in bug 1288301 can be used as a model to convert the rest of the tests.
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.