1238615 - Compiler warning: possibly uninitialized |rv| - mailnews/base/src/nsMsgPrintEngine.cpp

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[ISHIKAWA, Chiaki]

Attachment: warning-nsMsgPrintEngine.patch

During local testing of my new patches for C-C TB to make sure that my
patches do not introduce new warnings (at least under linux where I
compile and test), I noticed a compiler warning from
nsMsgPrintEngine.cpp.

As I looked, |rv| ought to be initialized during normal processing.
But the logic seems a little twisted (see the comment in the code),
and obscure.

So even if |rv| may be properly initialized during normal processing, try telling it to the compiler and future community maintainers.

I simply set a default error value and added an error case handling
although the error ought to be rare. (The code is much saner with the |else| part.)

This shuts up the compiler warning (e.g., gcc 5.3).

Comment 1

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8706430 [details] [diff] [review]
warning-nsMsgPrintEngine.patch

Review of attachment 8706430 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me with that fixed.

::: mailnews/base/src/nsMsgPrintEngine.cpp
@@ +494,5 @@
>                             nullptr,                            // Referring URI
>                             nullptr,                            // Post data
>                             nullptr);                           // Extra headers
> +    else // we should report the error (!)
> +       rv = NS_ERROR_FAILURE;

If we've already initialized it above, I don't think we need to re-set it here…

Comment 2

[ISHIKAWA, Chiaki]

Attachment: Revoming a compiler warning: possibly uninitialized |rv|. carrying over r=bwinton

Updated patch. Carrying over r=bwinton. I will put checkin-needed keyword.

TIA

Comment 3

[:aceman]

https://hg.mozilla.org/comm-central/rev/9974e710d039