Closed
Bug 1238639
Opened 8 years ago
Closed 8 years ago
HeapAnalysesWorker.getCreationTime should throw when given an invalid path
Categories
(DevTools :: Memory, defect, P3)
DevTools
Memory
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: fitzgen, Assigned: jdescottes, Mentored)
Details
Attachments
(1 file)
It should throw (causing HeapAnalysesClient.getCreationTime's promise to be rejected) when given an invalid path, so that it is consistent with the rest of the response handlers which exhibit this behavior. https://dxr.mozilla.org/mozilla-central/source/devtools/shared/heapsnapshot/HeapAnalysesClient.js#60-62 https://dxr.mozilla.org/mozilla-central/source/devtools/shared/heapsnapshot/HeapAnalysesWorker.js#93 https://dxr.mozilla.org/mozilla-central/source/devtools/shared/heapsnapshot/tests/unit/test_HeapAnalyses_getCreationTime_01.js#38
Reporter | ||
Updated•8 years ago
|
Has STR: --- → irrelevant
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jdescottes
Assignee | ||
Comment 1•8 years ago
|
||
Try push https://treeherder.mozilla.org/#/jobs?repo=try&revision=84f5099f1dca
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/30509/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/30509/
Attachment #8706844 -
Flags: review?(nfitzgerald)
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8706844 [details] MozReview Request: Bug 1238639 - HeapAnalysesWorker getCreationTime throws when given non-existant path;r=fitzgen https://reviewboard.mozilla.org/r/30509/#review27321 \o/
Attachment #8706844 -
Flags: review?(nfitzgerald) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Thanks for the review! Try push got stuck, but all dt tests are now green. Adding checkin-needed.
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e6b66aa9b157
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment 7•8 years ago
|
||
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•