Closed Bug 1238682 Opened 8 years ago Closed 8 years ago

As a desktop client user, when in a Hello session opening a new tab should open about:home

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(firefox45 verified)

VERIFIED FIXED
Iteration:
46.3 - Jan 25
Tracking Status
firefox45 --- verified

People

(Reporter: RT, Assigned: Mardak)

References

Details

User Story

Currently opening a new tab when in a Hello session results in sharing the new tab which exposes part of the browsing history to the sharing session.

This bug aims at fixing that as follows:
- When in an active Hello session, opening a new tab results in opening about:home
- When NOT in an active Hello session the normal behavior applies to the new tab

Attachments

(3 files)

      No description provided.
Rank: 10
User Story: (updated)
Priority: -- → P1
Ian and Mark, this is something we'll need to fix in the current iteration although it was not discussed at today's planning meeting. Could you please help identify someone who could look into feasibility for it given there are unknowns around how it can be implemented?
Flags: needinfo?(standard8)
Flags: needinfo?(ianb)
Let's discuss this at the next standup.
Flags: needinfo?(standard8)
Flags: needinfo?(ianb)
Bug 1118285 created resource:///modules/NewTabURL.jsm which provides a way to override the new tab url with NewTabURL.override() and .reset().
Attached video v1 video
Assignee: nobody → edilee
Attachment #8706682 - Flags: review?(standard8)
Attachment #8706682 - Flags: review?(mdeboer)
Comment on attachment 8706682 [details] [review]
[loop] Mardak:bug-1238682-newtab > mozilla:master

I'm delaying review of this until after the standup, as I'd like to know what Ian was thinking (was it just resources, or something else).

Additionally there's obvious holes in the scope of this bug that I'd like to get clarified as to what is happening with them.
Attachment #8706682 - Flags: review?(standard8)
Attachment #8706682 - Flags: review?(mdeboer)
Attachment #8706682 - Flags: review?(mdeboer)
Attachment #8706682 - Flags: review?(edilee)
Attachment #8706682 - Flags: review?(edilee) → review?(standard8)
Comment on attachment 8706682 [details] [review]
[loop] Mardak:bug-1238682-newtab > mozilla:master

Works as advertised. Nice, Ed! I don't know if the scope holes mentioned in comment 6 have been filled/ resolved, but as far as I'm concerned this is neat improvement.
Ship it!
Attachment #8706682 - Flags: review?(standard8)
Attachment #8706682 - Flags: review?(mdeboer)
Attachment #8706682 - Flags: review+
Status: NEW → ASSIGNED
https://github.com/mozilla/loop/commit/07e71fa400fe4e937819ba860b648cccc746b5d5
Status: ASSIGNED → RESOLVED
Iteration: --- → 46.3 - Jan 25
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 1239591
Blocks: 1239783
Ed: I think this should be using aboutNewTabService.newTabURL rather than NewTabURL.override(). See Bug 1204983 comment 89 (or check the deprecation warnings on the console).
Flags: needinfo?(edilee)
(In reply to Adam Roach [:abr] from comment #9)
> Ed: I think this should be using aboutNewTabService.newTabURL rather than
> NewTabURL.override(). See Bug 1204983 comment 89 (or check the deprecation
> warnings on the console).

Ah, never mind -- this appears to be a fast moving situation. I was looking at m-c, when m-i has removed the deprecation warnings. Sorry for the noise.
Flags: needinfo?(edilee)
Flags: qe-verify+
QA Contact: bogdan.maris
This is the beta version of the this bug plus the follow-up bug 1241063 that got the test working correctly.

I'll get a try push running in a moment.

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello tab sharing
[User impact if declined]: If a user opens a new tab whilst in a conversation, they may unexpectedly share history with the peer they are talking to. This changes about:newtab to about:home just whilst in a conversation.
[Describe test coverage new/current, TreeHerder]: This has been in the current add-on version for a while in m-c and m-a. It has its own tests.
[Risks and why]: Low, small change to loop specific code.
[String/UUID change made/needed]: None
Attachment #8722954 - Flags: approval-mozilla-beta?
Comment on attachment 8722954 [details] [diff] [review]
Patch for beta 45

As agreed, taking it. Should be in 45 beta 10
Attachment #8722954 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified across platforms (Windows 7 64-bit, Mac OS X 10.11 and Ubuntu 14.04 32-bit) that using Firefox 45 beta 10, opening a new window when in a conversation will open about:home instead.

Note that we found a few issues here during testing, we will investigate further and log dependencies to this.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Depends on: 1252439
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: