Closed Bug 1238704 Opened 8 years ago Closed 8 years ago

Use the same task descriptions for try and non-try jobs

Categories

(Taskcluster :: Services, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dustin, Assigned: dustin)

Details

Attachments

(3 files)

from mach_commands.py:

            # try builds don't use cache
            if project == "try":
                remove_caches_from_task(build_task)

so there's no reason to have yaml files specialized for try jobs.
OK, I'll have a patch shortly.  Diffing the graphs from before and after for a random commit, with dynamic stuff like timestamps and taskIds stripped, gives:

--- [TC] Linux32 Dbg B debug/before
+++ [TC] Linux32 Dbg B debug/after
@@ -86,7 +86,8 @@
         "docker-worker:cache:level-1-try-tc-vcs",
         "secrets:get:project/releng/gecko/build/level-1/*",
         "docker-worker:cache:tooltool-cache",
-        "docker-worker:relengapi-proxy:tooltool.download.public"
+        "docker-worker:relengapi-proxy:tooltool.download.public",
+        "docker-worker:cache:level-1-try-build-linux32-workspace"
     ],
     "tags": {
         "createdForUser": "eflores@mozilla.com"
--- [TC] Linux32 Opt B opt/before
+++ [TC] Linux32 Opt B opt/after
@@ -85,7 +85,8 @@
         "docker-worker:cache:level-1-try-tc-vcs",
         "secrets:get:project/releng/gecko/build/level-1/*",
         "docker-worker:cache:tooltool-cache",
-        "docker-worker:relengapi-proxy:tooltool.download.public"
+        "docker-worker:relengapi-proxy:tooltool.download.public",
+        "docker-worker:cache:level-1-try-build-linux32-workspace"
     ],
     "tags": {
         "createdForUser": "eflores@mozilla.com"
--- [TC] Linux64 Artifact Opt AB opt/before
+++ [TC] Linux64 Artifact Opt AB opt/after
@@ -87,7 +87,8 @@
         "docker-worker:cache:level-1-try-tc-vcs",
         "secrets:get:project/releng/gecko/build/level-1/*",
         "docker-worker:cache:tooltool-cache",
-        "docker-worker:relengapi-proxy:tooltool.download.public"
+        "docker-worker:relengapi-proxy:tooltool.download.public",
+        "docker-worker:cache:level-1-try-build-linux64-artifact-workspace"
     ],
     "tags": {
         "createdForUser": "eflores@mozilla.com"
--- [TC] Linux64 Dbg B debug/before
+++ [TC] Linux64 Dbg B debug/after
@@ -85,7 +85,8 @@
         "docker-worker:cache:level-1-try-tc-vcs",
         "secrets:get:project/releng/gecko/build/level-1/*",
         "docker-worker:cache:tooltool-cache",
-        "docker-worker:relengapi-proxy:tooltool.download.public"
+        "docker-worker:relengapi-proxy:tooltool.download.public",
+        "docker-worker:cache:level-1-try-build-linux64-workspace"
     ],
     "tags": {
         "createdForUser": "eflores@mozilla.com"
--- [TC] Linux64 Opt B opt/before
+++ [TC] Linux64 Opt B opt/after
@@ -84,7 +84,8 @@
         "docker-worker:cache:level-1-try-tc-vcs",
         "secrets:get:project/releng/gecko/build/level-1/*",
         "docker-worker:cache:tooltool-cache",
-        "docker-worker:relengapi-proxy:tooltool.download.public"
+        "docker-worker:relengapi-proxy:tooltool.download.public",
+        "docker-worker:cache:level-1-try-build-linux64-workspace"
     ],
     "tags": {
         "createdForUser": "eflores@mozilla.com"
--- [TC] Linux64 Static Analysis Opt S opt/before
+++ [TC] Linux64 Static Analysis Opt S opt/after
@@ -86,7 +86,8 @@
         "docker-worker:cache:level-1-try-tc-vcs",
         "secrets:get:project/releng/gecko/build/level-1/*",
         "docker-worker:cache:tooltool-cache",
-        "docker-worker:relengapi-proxy:tooltool.download.public"
+        "docker-worker:relengapi-proxy:tooltool.download.public",
+        "docker-worker:cache:level-1-try-build-linux64-st-an-workspace"
     ],
     "tags": {
         "createdForUser": "eflores@mozilla.com"
--- [TC] MacOSX64 Dbg B debug/before
+++ [TC] MacOSX64 Dbg B debug/after
@@ -76,13 +76,16 @@
     "provisionerId": "aws-provisioner-v1",
     "routes": [
         "index.gecko.v1.try.revision.linux.None.macosx64.dbg",
-        "index.gecko.v1.try.latest.linux.macosx64.dbg"
+        "index.gecko.v1.try.latest.linux.macosx64.dbg",
+        "index.buildbot.branches.try.macosx64",
+        "index.buildbot.revisions.None.try.macosx64"
     ],
     "schedulerId": "task-graph-scheduler",
     "scopes": [
         "docker-worker:cache:level-1-try-tc-vcs",
         "secrets:get:project/releng/gecko/build/level-1/*",
         "docker-worker:cache:tooltool-cache",
+        "docker-worker:cache:level-1-try-build-macosx64-workspace",
         "docker-worker:relengapi-proxy:tooltool.download.internal",
         "docker-worker:relengapi-proxy:tooltool.download.public"
     ],
--- [TC] MacOSX64 Opt B opt/before
+++ [TC] MacOSX64 Opt B opt/after
@@ -75,13 +75,16 @@
     "provisionerId": "aws-provisioner-v1",
     "routes": [
         "index.gecko.v1.try.revision.linux.None.macosx64.opt",
-        "index.gecko.v1.try.latest.linux.macosx64.opt"
+        "index.gecko.v1.try.latest.linux.macosx64.opt",
+        "index.buildbot.branches.try.macosx64",
+        "index.buildbot.revisions.None.try.macosx64"
     ],
     "schedulerId": "task-graph-scheduler",
     "scopes": [
         "docker-worker:cache:level-1-try-tc-vcs",
         "secrets:get:project/releng/gecko/build/level-1/*",
         "docker-worker:cache:tooltool-cache",
+        "docker-worker:cache:level-1-try-build-macosx64-workspace",
         "docker-worker:relengapi-proxy:tooltool.download.internal",
         "docker-worker:relengapi-proxy:tooltool.download.public"
     ],
--- [TC] MacOSX64 Static Analysis Opt S opt/before
+++ [TC] MacOSX64 Static Analysis Opt S opt/after
@@ -87,6 +87,7 @@
         "docker-worker:cache:level-1-try-tc-vcs",
         "secrets:get:project/releng/gecko/build/level-1/*",
         "docker-worker:cache:tooltool-cache",
+        "docker-worker:cache:level-1-try-build-macosx64-st-an-workspace",
         "docker-worker:relengapi-proxy:tooltool.download.internal",
         "docker-worker:relengapi-proxy:tooltool.download.public"
     ],


Most of that is added cache scopes, which don't hurt.  There are some added `buildbot` routes, but I confirmed with mshal that those won't hurt -- they're already being used by mozharness to upload similar jobs from buildbot.
For each of macosx64, linux32, and linux64, this creates a new
base_<platform>.yml file that is then specialized into opt, opt st-in,
artifact, and dbg variants.  The base contains the workspace cache,
but the `mach taskcluster-graph` removes it for try jobs.

Review commit: https://reviewboard.mozilla.org/r/42251/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42251/
Attachment #8734455 - Flags: review?(wcosta)
Attachment #8734455 - Flags: review?(wcosta) → review+
Comment on attachment 8734455 [details]
MozReview Request: Bug 1238704: remove special-casing of clobber jobs; r?wcosta

https://reviewboard.mozilla.org/r/42251/#review38799
https://hg.mozilla.org/mozilla-central/rev/c9e6dcefcfe8
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: Integration → Services
You need to log in before you can comment on or make changes to this bug.