1238747 - Inspector offers only -moz values in drop-down for "display" property

Status: RESOLVED DUPLICATE of bug 1260419

(DevTools :: Inspector: Rules, defect, P2)

Description

[Michael Hohner]

Attachment: Screenshot

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20160105164030

Steps to reproduce:

Open Inspector, edit styles of element, add "display" rule, don't enter value, press cursor down to open drop-down with possible values for "display" property.


Actual results:

Only "-moz" values are offered, not any standard value (see screenshot). This does not happen for e.g. the "overflow" property.


Expected results:

All possible values should be offered, -moz and standard.

Comment 1

[Michael Hohner]

2 months, and zero reactions?

Comment 2

[Patrick Brosset <:pbro>]

(In reply to Michael Hohner from comment #1)
> 2 months, and zero reactions?
This somehow didn't show up on my radar.
This is very annoying indeed.
Bug 1168246 should make this a lot better (by sorting autocompleted items by popularity).

I wonder if there's something quick we could do in the meantime to make the completion of the display property better, or if we just need to wait for bug 1168246 to be done.

Comment 3

[Michael Hohner]

Maybe I misunderstand bug 1168246, but the problem here is that none of the standard values are in the drop-down list, not that they are in the wrong order.

Comment 4

[Patrick Brosset <:pbro>]

(In reply to Michael Hohner from comment #3)
> Maybe I misunderstand bug 1168246, but the problem here is that none of the
> standard values are in the drop-down list, not that they are in the wrong
> order.
Oh right, sorry for the confusion.

In bug 1168246, if you've started typing say, "w" in the property *name* input, then the list of property names presented should be in an order that makes sense (so "width" first for instance).

In the case of the problem described here however, we're talking about property *values* and moreover, values presented after you've just focused the input field, not after you've started typing.

I still think these 2 are related though. In bug 1168246 we want to have a way to sort property names by popularity. In the bug here, I think we should sort property values by popularity.
The reason why you only see values starting with "-moz" after you've typed "display" is because the dropdown list cuts off the results after 10 entries [0].
Changing this to 50 shows the expected inline, grid, flex, block, ... entries.
For reference, here is what Gecko currently considers as valid values for "display":

-moz-box,-moz-deck,-moz-grid,-moz-grid-group,-moz-grid-line,-moz-groupbox,-moz-inline-box,-moz-inline-grid,-moz-inline-stack,-moz-popup,-moz-stack,block,contents,flex,grid,inherit,initial,inline,inline-block,inline-flex,inline-grid,inline-table,list-item,none,ruby,ruby-base,ruby-base-container,ruby-text,ruby-text-container,table,table-caption,table-cell,table-column,table-column-group,table-footer-group,table-header-group,table-row,table-row-group,unset

So we could expand on bug 1168246 to also sort property values.
However, making it possible to just continue pressing DOWN in the dropdown list to access all values would be useful too. Right now, the way this list works is it cycles through the 10 results only.

[0] https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/inplace-editor.js#36

Comment 5

[Julian Descottes [:jdescottes]]

I am currently working on Bug 1260419 which will remove the limit of 10 displayed items.

This means the standard values will now be displayed, but they will still be after the "-moz-*" values.
I think it makes sense to go beyond the basic alphabetical sort here and put prefixed values at the end of the list.

They are in general less popular than standard values and should not pollute the view.

Since Bug 1260419 will make sure all properties are displayed, let's repurpose this bug to modify the sorting as described above.

Putting myself as mentor if anyone wants to take a look. The first step would be to modify _maybeSuggestCompletion in devtools' inplace editor [1]. In this method we create the list of suggestions that will be forwarded to the autocomplete popup. The sorting can be done here for now.

[1] https://hg.mozilla.org/integration/fx-team/file/30010c0e58af/devtools/client/shared/inplace-editor.js#l1190

Putting myself as mentor if anyone wants to have a look! Going to flag as good first bug, don't think this should be too complex.

Comment 6

[Julian Descottes [:jdescottes]]

I am stealing this and will fix it as part of Bug 1260419. Doing the different bugs separately means updating the same tests again (tests based on the suggestion order).

Don't think it makes too much sense to keep them separated even if it made for a nice first bug.