Closed Bug 1238755 Opened 7 years ago Closed 7 years ago

Make BasicCompositor a little faster on OS X using Skia

Categories

(Core :: Widget: Cocoa, defect)

Unspecified
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: mstange, Assigned: mstange)

Details

Attachments

(2 files)

No description provided.
Attachment #8706626 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8706626 [details]
MozReview Request: Bug 1238755 - Avoid a copy when uploading the BasicCompositor result to a texture. r?mattwoodrow

https://reviewboard.mozilla.org/r/30417/#review27137

::: widget/cocoa/nsChildView.mm:2942
(Diff revision 1)
> +    int32_t stride = size.width * 4;

Would prefer BytesPerPixel rather than 4
Comment on attachment 8706627 [details]
MozReview Request: Bug 1238755 - Use Skia for BasicCompositor composition. r?mattwoodrow

https://reviewboard.mozilla.org/r/30419/#review27141
Attachment #8706627 - Flags: review?(matt.woodrow) → review+
Summary: Make BasicCompositor a little faster on OS X → Make BasicCompositor a little faster on OS X using Skia
OS: Unspecified → Mac OS X
https://hg.mozilla.org/mozilla-central/rev/305fa4641686
https://hg.mozilla.org/mozilla-central/rev/ff537450e059
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.