1238755 - Make BasicCompositor a little faster on OS X using Skia

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Comment 1

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1238755 - Avoid a copy when uploading the BasicCompositor result to a texture. r?mattwoodrow

Review commit: https://reviewboard.mozilla.org/r/30417/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30417/

Comment 2

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1238755 - Use Skia for BasicCompositor composition. r?mattwoodrow

Review commit: https://reviewboard.mozilla.org/r/30419/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30419/

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8706626 [details]
MozReview Request: Bug 1238755 - Avoid a copy when uploading the BasicCompositor result to a texture. r?mattwoodrow

https://reviewboard.mozilla.org/r/30417/#review27137

::: widget/cocoa/nsChildView.mm:2942
(Diff revision 1)
> +    int32_t stride = size.width * 4;

Would prefer BytesPerPixel rather than 4

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8706627 [details]
MozReview Request: Bug 1238755 - Use Skia for BasicCompositor composition. r?mattwoodrow

https://reviewboard.mozilla.org/r/30419/#review27141

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/305fa4641686
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff537450e059

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/305fa4641686
https://hg.mozilla.org/mozilla-central/rev/ff537450e059