Closed
Bug 1238769
Opened 7 years ago
Closed 7 years ago
Add a -xpcshell option to Firefox
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 47
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
4.17 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Now that xpcshell is just a (literal) shell around XRE_XPCShellMain, we can actually just make Firefox itself work as the xpcshell.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8706654 -
Flags: review?(benjamin)
Updated•7 years ago
|
Attachment #8706654 -
Flags: review?(benjamin) → review+
Comment 3•7 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/2c9e3adfb02e for the "what is this environ of which you speak?" of https://treeherder.mozilla.org/logviewer.html#?job_id=21048823&repo=mozilla-inbound
Assignee | ||
Comment 4•7 years ago
|
||
Big facepalm on my part. Trivial change to make it build on all platforms.
Attachment #8706654 -
Attachment is obsolete: true
Attachment #8715823 -
Flags: review?(benjamin)
Updated•7 years ago
|
Attachment #8715823 -
Flags: review?(benjamin) → review+
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f5c043dfcb47
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Comment 7•6 years ago
|
||
So is this supposed to do something now? firefox -xpcshell toolkit/components/autocomplete/tests/unit/test_finalCompleteValue_forceComplete.js It just produces no output and finishes.
Flags: needinfo?(mh+mozilla)
Assignee | ||
Comment 8•6 years ago
|
||
(In reply to Magnus Melin from comment #7) > So is this supposed to do something now? > > firefox -xpcshell > toolkit/components/autocomplete/tests/unit/ > test_finalCompleteValue_forceComplete.js > > It just produces no output and finishes. It works for me on Linux, but I can reproduce on Windows. Unfortunately, I can't tell why it does that. Following with a debugger says it exists through https://dxr.mozilla.org/mozilla-central/rev/ae7413abfa4d3954a6a4ce7c1613a7100f367f9a/js/xpconnect/src/XPCShellImpl.cpp#1593 Bobby, any ideas? (this should probably be filed as a separate bug)
Flags: needinfo?(mh+mozilla) → needinfo?(bobbyholley)
Comment 9•6 years ago
|
||
FWIW, I was testing on linux (though with a nightly, not a local build).
Comment 10•6 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #8) > (In reply to Magnus Melin from comment #7) > > So is this supposed to do something now? > > > > firefox -xpcshell > > toolkit/components/autocomplete/tests/unit/ > > test_finalCompleteValue_forceComplete.js > > > > It just produces no output and finishes. > > It works for me on Linux, but I can reproduce on Windows. Unfortunately, I > can't tell why it does that. Following with a debugger says it exists > through > https://dxr.mozilla.org/mozilla-central/rev/ > ae7413abfa4d3954a6a4ce7c1613a7100f367f9a/js/xpconnect/src/XPCShellImpl. > cpp#1593 > Bobby, any ideas? (this should probably be filed as a separate bug) That must means that something in ProcessArgs threw an exception or otherwise caused us to return false. You'll need to step into that function to get to the source.
Flags: needinfo?(bobbyholley)
You need to log in
before you can comment on or make changes to this bug.
Description
•