1238769 - Add a -xpcshell option to Firefox

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mike Hommey [:glandium]]

Now that xpcshell is just a (literal) shell around XRE_XPCShellMain, we can actually just make Firefox itself work as the xpcshell.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Add a -xpcshell option to Firefox

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7af06ac5c280

Comment 3

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/2c9e3adfb02e for the "what is this environ of which you speak?" of https://treeherder.mozilla.org/logviewer.html#?job_id=21048823&repo=mozilla-inbound

Comment 4

[Mike Hommey [:glandium]]

Attachment: Add a -xpcshell option to Firefox

Big facepalm on my part. Trivial change to make it build on all platforms.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5c043dfcb47

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f5c043dfcb47

Comment 7

[Magnus Melin [:mkmelin]]

So is this supposed to do something now?

firefox -xpcshell toolkit/components/autocomplete/tests/unit/test_finalCompleteValue_forceComplete.js

It just produces no output and finishes.

Comment 8

[Mike Hommey [:glandium]]

(In reply to Magnus Melin from comment #7)
> So is this supposed to do something now?
> 
> firefox -xpcshell
> toolkit/components/autocomplete/tests/unit/
> test_finalCompleteValue_forceComplete.js
> 
> It just produces no output and finishes.

It works for me on Linux, but I can reproduce on Windows. Unfortunately, I can't tell why it does that. Following with a debugger says it exists through https://dxr.mozilla.org/mozilla-central/rev/ae7413abfa4d3954a6a4ce7c1613a7100f367f9a/js/xpconnect/src/XPCShellImpl.cpp#1593
Bobby, any ideas? (this should probably be filed as a separate bug)

Comment 9

[Magnus Melin [:mkmelin]]

FWIW, I was testing on linux (though with a nightly, not a local build).

Comment 10

[Bobby Holley (:bholley)]

(In reply to Mike Hommey [:glandium] from comment #8)
> (In reply to Magnus Melin from comment #7)
> > So is this supposed to do something now?
> > 
> > firefox -xpcshell
> > toolkit/components/autocomplete/tests/unit/
> > test_finalCompleteValue_forceComplete.js
> > 
> > It just produces no output and finishes.
> 
> It works for me on Linux, but I can reproduce on Windows. Unfortunately, I
> can't tell why it does that. Following with a debugger says it exists
> through
> https://dxr.mozilla.org/mozilla-central/rev/
> ae7413abfa4d3954a6a4ce7c1613a7100f367f9a/js/xpconnect/src/XPCShellImpl.
> cpp#1593
> Bobby, any ideas? (this should probably be filed as a separate bug)

That must means that something in ProcessArgs threw an exception or otherwise caused us to return false. You'll need to step into that function to get to the source.