Closed Bug 1238817 Opened 8 years ago Closed 8 years ago

[fling-player][TV][2.5] Display confirm dialog and kill fling app if user confirm close

Categories

(Firefox OS Graveyard :: Gaia::TV::Fling, defect, P1)

defect

Tracking

(blocking-b2g:2.5+, b2g-v2.5 verified, b2g-master verified)

VERIFIED FIXED
2.6 S6 - 1/29
blocking-b2g 2.5+
Tracking Status
b2g-v2.5 --- verified
b2g-master --- verified

People

(Reporter: jocheng, Assigned: Fischer)

References

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick])

Attachments

(2 files)

(Only in 2.5)
When user press back key, we need to display a confirmation dialog and call 
window.close() to kill itself.
Hi Fischer,
Please help this. Thanks.
Assignee: nobody → fliu
blocking-b2g: --- → 2.5+
Flags: needinfo?(fliu)
No longer blocks: TV_FTE
Please use "Do you want to end video playback?" string for user confirmation dialog.
QA Whiteboard: [COM=TV Seamless Experience]
@Josh,
Just double check that only for v2.5 or for v2.5 + master, thank you
Flags: needinfo?(jocheng)
Correct to my description 0. This approach is for 2.5 only. After 2.5 we will consider handle back key overally in system.
Flags: needinfo?(jocheng)
(In reply to [:Fischer]Fischer from comment #7)
> @Josh,
> Just double check that only for v2.5 or for v2.5 + master, thank you

We need this both master and 2.5. Thanks
Flags: needinfo?(fliu)
Comment on attachment 8708260 [details] [review]
[gaia] Fischer-L:bug_1238817-back-key-to-kill-fling-player > mozilla-b2g:master

@Rex,
This patch would ask user's confirmation to end fling player on back key pressed.
Please see test_confirm_to_end_fling-player_on_tv_by_back_key.png attached.
That is the test on a real TV, thank you.
Attachment #8708260 - Flags: review?(rexboy)
Comment on attachment 8708260 [details] [review]
[gaia] Fischer-L:bug_1238817-back-key-to-kill-fling-player > mozilla-b2g:master

Looks good to me!
Attachment #8708260 - Flags: review?(rexboy) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 8708260 [details] [review]
[gaia] Fischer-L:bug_1238817-back-key-to-kill-fling-player > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1238817
[User impact] if declined: Unable to leave fling player by pressing Back key
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: Yes
Attachment #8708260 - Flags: approval-gaia-v2.5?(jocheng)
Comment on attachment 8708260 [details] [review]
[gaia] Fischer-L:bug_1238817-back-key-to-kill-fling-player > mozilla-b2g:master

Approve for TV 2.5
Attachment #8708260 - Flags: approval-gaia-v2.5?(jocheng) → approval-gaia-v2.5+
Depends on: 1241366
No longer depends on: 1241366
You need to log in before you can comment on or make changes to this bug.