Closed Bug 1238866 Opened 4 years ago Closed 4 years ago

[Ubuntu] "Add search engine" in search panel has white background with GTK3 and dark theme

Categories

(Firefox :: Theme, defect)

45 Branch
All
Linux
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 48
Tracking Status
firefox45 --- unaffected
firefox46 --- wontfix
firefox48 --- verified

People

(Reporter: petruta.rasa, Assigned: rakhisharma, Mentored)

References

Details

(Keywords: regression, Whiteboard: [lang=css][good first bug])

Attachments

(2 files)

Attached image Add search engine.png
Mozilla/5.0 (X11; Linux i686; rv:46.0) Gecko/20100101 Firefox/46.0

Reproducible on latest Nightly 46.0a1 and latest Aurora 45.0a2 (2016-01-11):
Not reproducible on Firefox 44 beta 7.

Steps to reproduce:
1. Go to https://addons.mozilla.org/en-US/firefox/extensions/?sort=hotness 
2. Open the search toolbox and notice "Add Firefox Add-ons" area

Actual results:
Inconsistency between panel's zones. This could be a follow-up from bug 1187393.

Expected results:
The "Add.." area has a dark background, just like the rest of the panel.
Mentor: gijskruitbosch+bugs
This will need to change the 'background-color: Menu' that was added in bug 1187393 to something more appropriate (potentially just removing it, but that would need testing).
Whiteboard: [lang=css][good first bug]
Hi

I am new to this world and I want to start working on this as my first bug. 

Can I take this Bug ?
(In reply to archit.knsl from comment #2)
> Hi
> 
> I am new to this world and I want to start working on this as my first bug. 
> 
> Can I take this Bug ?

Welcome! Yes, you can totally work on this bug. The best thing to do would be to start working on it, and once you have a patch, to attach it as an attachment or via mozreview. We can change the "assignee" field on the bug once you have a first patch. :-)
hey GIjs.
I visited the page https://addons.mozilla.org/en-US/firefox/extensions/?sort=hotness

on this page on top right i found a search box..
and there is also a "SEARCH TOOLS" in the "More" options.
whr do i go to find "Add Firefox Add-ons" area...couldnt find it
I would love if u could guide to where and what changes need to be made :)
(In reply to Ritesh Giri from comment #4)
> hey GIjs.
> I visited the page
> https://addons.mozilla.org/en-US/firefox/extensions/?sort=hotness
> 
> on this page on top right i found a search box..
> and there is also a "SEARCH TOOLS" in the "More" options.
> whr do i go to find "Add Firefox Add-ons" area...couldnt find it
> I would love if u could guide to where and what changes need to be made :)

The search toolbox in comment #0 is the Firefox search field that's in your browser toolbar. This bug is about the browser's UI, rather than about addons.mozilla.org specifically. See also comment #1 and the patch from the bug referenced there.

Note that archit was the first to ask if they could work on this, and they only did so less than 48 hours ago, so right now it might be better if you found a different bug to work on.
ohk Gijks..
will find another bug to work on... 
thanks :)
Thank you , Gijs.

I have started working on the bug. I will soon send you an Update.
The switch to Gtk+3 was delayed to 46, so this doesn't affect 45.
Doesn't look like something we'd need to uplift to beta.
Hi Archit,

Are you working on this bug? I also want to work on this bug. Please let me know if you are not working.This is great if you are working :)
Flags: needinfo?(archit.knsl)
Attachment #8736314 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8736314 [details]
MozReview Request: Bug 1238866 - [Ubuntu] "Add search engine" in search panel has white background with GTK3 and dark theme, r?gijs.

https://reviewboard.mozilla.org/r/43209/#review39797

::: browser/themes/linux/searchbar.css:167
(Diff revision 1)
>  }
>  
>  .addengine-item {
>    -moz-appearance: none;
> +  background-color: Menu;
> +  color: HighlightText;

Hm, shouldn't this be MenuText ? Does that work, too? (can you provide a screenshot of both cases?)
Comment on attachment 8736314 [details]
MozReview Request: Bug 1238866 - [Ubuntu] "Add search engine" in search panel has white background with GTK3 and dark theme, r?gijs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43209/diff/1-2/
Attachment #8736314 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8736314 [details]
MozReview Request: Bug 1238866 - [Ubuntu] "Add search engine" in search panel has white background with GTK3 and dark theme, r?gijs.

https://reviewboard.mozilla.org/r/43209/#review39821

Looks good to me, thanks!
Attachment #8736314 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/364b20e86805
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Assignee: nobody → Rakhish1994
I've managed to reproduce this bug on Nightly 46.0a1 (2016-01-11) (Build ID : 20160111030207) on Linux, 64 Bit.

This Bug is now verified as fixed on Latest Firefox Nightly 48.0a2 (2016-05-05)

Build ID: 20160505004017
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0
OS: Ubuntu 16.04 ; Linux 4.4.0-21-generic x86-64
QA Whiteboard: [bugday-20160504]
Flags: needinfo?(archit.knsl)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.