Closed
Bug 1238870
Opened 8 years ago
Closed 8 years ago
[TV][2.5]Listen to Backspace not esc key for back function
Categories
(Firefox OS Graveyard :: Gaia::TV, defect, P1)
Tracking
(blocking-b2g:2.5+, b2g-v2.5 verified, b2g-master verified)
VERIFIED
FIXED
blocking-b2g | 2.5+ |
People
(Reporter: jocheng, Assigned: rickychien)
References
Details
(Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker])
Attachments
(1 file, 4 obsolete files)
46 bytes,
text/x-github-pull-request
|
lchang
:
review+
jocheng
:
approval-gaia-v2.5+
|
Details | Review |
Back function should listen to "Backspace" key not "Esc" key.
Reporter | ||
Comment 1•8 years ago
|
||
@Dan, Please also help to update MDN about key mapping. Thanks
Blocks: TV_P1
blocking-b2g: --- → 2.5+
Flags: needinfo?(dhuang)
Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker]
Reporter | ||
Updated•8 years ago
|
Reporter | ||
Comment 2•8 years ago
|
||
Hi David, Please aware about the change and notify 3rd developers afterward. This is to align current partner implementation.
Flags: needinfo?(dwalsh)
Comment 3•8 years ago
|
||
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8706820 [details] [review] [gaia] rickychien:backspaceToBack > mozilla-b2g:master Luke, here is a simple patch for replacing ESC with Backspace.
Attachment #8706820 -
Flags: review?(lchang)
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Comment 5•8 years ago
|
||
updated: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/TVs_connected_devices/TV_remote_control_button_mapping_to_keyboard
Flags: needinfo?(dhuang)
Comment 6•8 years ago
|
||
This change will effect 2.5+ on TV, correct?
Assignee | ||
Comment 7•8 years ago
|
||
(In reply to Michael Ellis from comment #6) > This change will effect 2.5+ on TV, correct? yes
Comment 8•8 years ago
|
||
Comment on attachment 8706820 [details] [review] [gaia] rickychien:backspaceToBack > mozilla-b2g:master R+ with comments on GitHub. Please take a look. BTW, you may need to modify the corresponding smart components as well.
Attachment #8706820 -
Flags: review?(lchang) → review+
Comment 9•8 years ago
|
||
Comment 10•8 years ago
|
||
Assignee | ||
Comment 11•8 years ago
|
||
Thank you Luke, follow up patches for corresponding smart-components are being filed. Landed in master: https://github.com/mozilla-b2g/gaia/commit/2d6c11a1e82bd9f9b7491863c8d1ea4a14aea69f Landed in smart-dialog https://github.com/smart-components/smart-dialog/commit/a18be5a9eea166ca91da7fb114fce7f98ff21e08
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 12•8 years ago
|
||
Comment on attachment 8707738 [details] [review] [gaia] rickychien:backspaceToBack > mozilla-b2g:master Previous patch has been reverted since I forgot to sync all modified comments in smart-dialog. New patch fixes these forgotten comments and have re-landed in master.
Assignee | ||
Comment 13•8 years ago
|
||
Comment on attachment 8707738 [details] [review] [gaia] rickychien:backspaceToBack > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): bug 1214243 [User impact] if declined: unable to align partner's physical remote controller implementation [Testing completed]: manual verified / tested on local [Risk to taking this patch] (and alternatives if risky): minor [String changes made]: n/a
Attachment #8707738 -
Flags: approval-gaia-v2.5?
Reporter | ||
Comment 14•8 years ago
|
||
Comment on attachment 8707738 [details] [review] [gaia] rickychien:backspaceToBack > mozilla-b2g:master Approve for TV 2.5
Attachment #8707738 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
Assignee | ||
Updated•8 years ago
|
Attachment #8707738 -
Flags: approval-gaia-v2.5+
Comment 15•8 years ago
|
||
Assignee | ||
Comment 16•8 years ago
|
||
Revert https://github.com/mozilla-b2g/gaia/commit/e59727554e22f0290400959c0a2d26a7cac68f11 Due to backspace affecting normal keyboard delete behavior so we decided to back this out.
Assignee | ||
Updated•8 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 18•8 years ago
|
||
As our offline discussion, let's try to detect the current status of keyboard app before handling "backspace" key in system app.
Comment 19•8 years ago
|
||
Assignee | ||
Comment 20•8 years ago
|
||
Comment on attachment 8706820 [details] [review] [gaia] rickychien:backspaceToBack > mozilla-b2g:master >https://github.com/mozilla-b2g/gaia/pull/33838
Attachment #8706820 -
Attachment is obsolete: true
Assignee | ||
Comment 21•8 years ago
|
||
Comment on attachment 8707737 [details] [review] [gaia] mozilla-b2g:revert-33838-backspaceToBack > mozilla-b2g:master >https://github.com/mozilla-b2g/gaia/pull/33863
Attachment #8707737 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Attachment #8708166 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Attachment #8712488 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Attachment #8707738 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Attachment #8712488 -
Attachment is obsolete: false
Assignee | ||
Comment 22•8 years ago
|
||
Comment on attachment 8712488 [details] [review] [gaia] rickychien:esc-backspace > mozilla-b2g:master I knew we're waiting for this a few days ago.
Attachment #8712488 -
Flags: review?(lchang)
Reporter | ||
Updated•8 years ago
|
Priority: -- → P1
Reporter | ||
Comment 23•8 years ago
|
||
Hi Ricky, Could this been fixed by Jan 29?
Flags: needinfo?(rchien)
Comment 25•8 years ago
|
||
Comment on attachment 8712488 [details] [review] [gaia] rickychien:esc-backspace > mozilla-b2g:master Nice work!
Attachment #8712488 -
Flags: review?(lchang) → review+
Assignee | ||
Comment 26•8 years ago
|
||
Landed in master: https://github.com/mozilla-b2g/gaia/commit/c5dec163d4b33c56d7491f00be69c0a9ff471a7d
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 27•8 years ago
|
||
Comment on attachment 8712488 [details] [review] [gaia] rickychien:esc-backspace > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): bug 1214243 [User impact] if declined: unable to align partner's physical remote controller implementation [Testing completed]: manual verified / tested on local [Risk to taking this patch] (and alternatives if risky): minor [String changes made]: N/A
Attachment #8712488 -
Flags: approval-gaia-v2.5?
Reporter | ||
Comment 28•8 years ago
|
||
Comment on attachment 8712488 [details] [review] [gaia] rickychien:esc-backspace > mozilla-b2g:master Approved for TV 2.5
Attachment #8712488 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
Reporter | ||
Updated•8 years ago
|
Assignee | ||
Comment 29•8 years ago
|
||
Landed in smart-component's master https://github.com/smart-components/smart-dialog/commit/6d4ee294127fdfc03f67573193e9fc7a4add45f2
Comment 30•8 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/01cafaf491834425b8ff752d4395f8048a804cbf
Comment 31•8 years ago
|
||
This issue is verified on v2.5 and v2.6 latest build. Backspace key works instead of ESC key now and it will detect the current status of keyboard app before handling "backspace" key in system app. [Build Info] 2.6 TV Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/5b90c09648798d8d66c4b08f81402b27acf0dc08 gecko: https://hg.mozilla.org/mozilla-central/rev/05c087337043dd8e71cc27bdb5b9d55fd00aaa26 2.5 TV Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/81460a1025c357ca8a52e5bc8647fff6bb005638 gecko: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/240426e9718eab5661517e3f9ad6173819284615 mulet: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•