1238878 - Do Flush command after EOS for MSE.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Alfredo Yang (:alfredo)]

MediaFormatReader could send more data after calling Drain (send EOS in OmxDataDecoder) in MSE case. In OMX, it won't accept any input after EOS, to fix it, we need to call flush command to reset decoder [1].

[1] spec 3.2.2.4 OMX_CommandFlush:
"When a port is flushed, the component shall reset any internal state associated with the port so as to be ready to process from another location within the stream after the flush."

Comment 1

[Alfredo Yang (:alfredo)]

Attachment: reset_decoder_after_eos

Comment 2

[Alfredo Yang (:alfredo)]

I found this bug when trying dom/media/mediasource/test/test_BufferingWait_mp4.html.

Comment 3

[Jean-Yves Avenard [:jya]]

Do you think the MediaFormatReader should always issue a Flush() command after a drain?

Right now, following a drain, it may simply re-seek in the media and start feeding new data to the decoder.

Comment 4

[Alfredo Yang (:alfredo)]

(In reply to Jean-Yves Avenard [:jya] from comment #3)
> Do you think the MediaFormatReader should always issue a Flush() command
> after a drain?
> 
> Right now, following a drain, it may simply re-seek in the media and start
> feeding new data to the decoder.

Yes, it'd be better IMHO.

Comment 5

[Alfredo Yang (:alfredo)]

1. Refine log
2. call flush after eos

Comment 6

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8706815 [details] [diff] [review]
reset_decoder_after_eos

LGTM.

Comment 7

[Alfredo Yang (:alfredo)]

Attachment: reset_decoder_after_eos

After this patch, all 2015 MSE tests [1] are passed. (you need to press play button in test 20 and 42 due to preload is off on b2g IIRC)

[1] http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2015.html?timestamp=1452850350917

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f02ddf84813

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9f02ddf84813