Closed Bug 1238896 Opened 8 years ago Closed 4 years ago

IPC: Fix include wrong build_config.h

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: hev, Assigned: hev)

Details

Attachments

(1 file)

Looks media/webrtc/trunk/build/build_config.h included by ipc/chromium/src/base/port.h at building for mips, I think the right path is ipc/chromium/src/build/build_config.h.
Attachment #8706839 - Flags: review?(mh+mozilla)
Comment on attachment 8706839 [details] [diff] [review]
0001-IPC-Fix-include-wrong-build_config.h.patch

Review of attachment 8706839 [details] [diff] [review]:
-----------------------------------------------------------------

This is most certainly not the right thing to do, but without knowing what the actual error you got was from building what file, I can't tell more.
Attachment #8706839 - Flags: review?(mh+mozilla) → review-
I'm building firefox 43 for mips64. I got a wrong implementation of this function (http://lxr.mozilla.org/mozilla-central/source/ipc/chromium/src/base/process_util.h#78) inlined in that function (http://lxr.mozilla.org/mozilla-central/source/ipc/glue/GeckoChildProcessHost.cpp#275) because macro 'ARCH_CPU_MIPS' not definied. In fact, this macro defined in file (http://lxr.mozilla.org/mozilla-central/source/ipc/chromium/src/build/build_config.h#91). I try recompile with "-E", looks like wrong 'build_config.h' included:

# grep "build_config" GeckoChildProcessHost.with-e
# 1 "/home/heiher/git/mips64/gecko-dev/media/webrtc/trunk/build/build_config.h" 1
What do you think? thx!
Flags: needinfo?(mh+mozilla)
media/webrtc/trunk/build/build_config.h has ARCH_CPU_MIPS defined for __mips__, but it doesn't have the mips64 codepath that ipc/chromium/src/build/build_config.h has. You just need to fix that.
Flags: needinfo?(mh+mozilla)
(In reply to Mike Hommey [:glandium] from comment #5)
> media/webrtc/trunk/build/build_config.h has ARCH_CPU_MIPS defined for
> __mips__, but it doesn't have the mips64 codepath that
> ipc/chromium/src/build/build_config.h has. You just need to fix that.

Yes, I agree this is a solution. As you can see that build_config.h of webkit applied to ipc, Is this correct?
(In reply to Heiher [:hev] from comment #6)
> (In reply to Mike Hommey [:glandium] from comment #5)
> > media/webrtc/trunk/build/build_config.h has ARCH_CPU_MIPS defined for
> > __mips__, but it doesn't have the mips64 codepath that
> > ipc/chromium/src/build/build_config.h has. You just need to fix that.
> 
> Yes, I agree this is a solution. As you can see that build_config.h of
> webkit applied to ipc, Is this correct?

Could you help me? thx!
Flags: needinfo?(mh+mozilla)
What is your question?
Flags: needinfo?(mh+mozilla) → needinfo?(r)
(In reply to Mike Hommey [:glandium] from comment #8)
> What is your question?

Oh. Looks webrtc included the build_config.h in ipc/chromium. why not it-self?
Flags: needinfo?(r)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
(In reply to Mike Hommey [:glandium] from comment #8)
> What is your question?

The question is ipc/glue/BackgroundChildImpl.cpp include media/webrtc/trunk/build/build_config.h, but the right is ./ipc/chromium/src/build/build_config.h

Why? please looks build log:
/opt/mips64el-toolchain/bin/mips64el-unknown-linux-gnu-g++ -std=gnu++11 -o BackgroundChildImpl.o -c -I/home/heiher/git/mips64/firefox/obj-mips64el-unknown-linux-gnu/dist/stl_wrappers -I/home/heiher/git/mips64/firefox/obj-mips64el-unknown-linux-gnu/dist/system_wrappers -include /home/heiher/git/mips64/firefox/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DWEBRTC_POSIX -DOS_POSIX=1 -DOS_LINUX=1 '-DMOZ_CHILD_PROCESS_NAME="plugin-container"' '-DMOZ_CHILD_PROCESS_NAME_PIE=""' '-DMOZ_CHILD_PROCESS_BUNDLE="plugin-container.app/Contents/MacOS/"' '-DDLL_PREFIX="lib"' '-DDLL_SUFFIX=".so"' -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/home/heiher/git/mips64/firefox/ipc/glue -I/home/heiher/git/mips64/firefox/obj-mips64el-unknown-linux-gnu/ipc/glue -I/home/heiher/git/mips64/firefox/caps -I/home/heiher/git/mips64/firefox/dom/broadcastchannel -I/home/heiher/git/mips64/firefox/dom/indexedDB -I/home/heiher/git/mips64/firefox/dom/workers -I/home/heiher/git/mips64/firefox/media/webrtc/trunk -I/home/heiher/git/mips64/firefox/xpcom/build -I/home/heiher/git/mips64/firefox/dom/ipc -I/home/heiher/git/mips64/firefox/toolkit/crashreporter -I/home/heiher/git/mips64/firefox/toolkit/xre -I/home/heiher/git/mips64/firefox/xpcom/threads -I/home/heiher/git/mips64/firefox/obj-mips64el-unknown-linux-gnu/ipc/ipdl/_ipdlheaders -I/home/heiher/git/mips64/firefox/ipc/chromium/src -I/home/heiher/git/mips64/firefox/ipc/glue -I/home/heiher/git/mips64/firefox/obj-mips64el-unknown-linux-gnu/dist/include  -I/home/heiher/git/mips64/firefox/obj-mips64el-unknown-linux-gnu/dist/include/nspr -I/home/heiher/git/mips64/firefox/obj-mips64el-unknown-linux-gnu/dist/include/nss   -Ino/include    -fPIC  -DMOZILLA_CLIENT -include /home/heiher/git/mips64/firefox/obj-mips64el-unknown-linux-gnu/mozilla-config.h -MD -MP -MF .deps/BackgroundChildImpl.o.pp  -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++14-compat -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -fno-lifetime-dse -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe  -O3 -march=loongson3a -mno-branch-likely -mno-shared -fomit-frame-pointer  -Wno-shadow  /home/heiher/git/mips64/firefox/ipc/glue/BackgroundChildImpl.cpp

In log, -I/home/heiher/git/mips64/firefox/media/webrtc/trunk and -I/home/heiher/git/mips64/firefox/ipc/chromium/src are contains build/build_config.h file, and -I/home/heiher/git/mips64/firefox/media/webrtc/trunk at first, so really include it.

This is right?
Flags: needinfo?(mh+mozilla)
Product: Core → Firefox Build System
Status: REOPENED → RESOLVED
Closed: 8 years ago4 years ago
Resolution: --- → WONTFIX
Flags: needinfo?(mh+mozilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: