1238987 - Remove the trailing newline when the quoted text in comments is wrapped

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[David Lawrence [:dkl]]

webservice_bug_comments.t and webservice_bug_update.t stopped passing due to changes introduced in bug 688205 that attempts to wrap cited comments. Reason is that even comments added via API that consist of a single line without a newline character, the same comment is returned with a newline character added which no longer matches.

Patch coming to address this.

dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: 1238987_1.patch

Comment 2

[Frédéric Buclin]

Comment on attachment 8706960 [details] [diff] [review]
1238987_1.patch

Simply call chomp($wrappedcomment) before returning it, see e.g. wrap_comment().

Comment 3

[David Lawrence [:dkl]]

Attachment: 1238987_2.patch

Ugh. Missed that in the other function. So sorry for over-engineering the issue :)

Comment 4

[Frédéric Buclin]

Comment on attachment 8706973 [details] [diff] [review]
1238987_2.patch

I didn't test your patch. But if this fixes the problem for you, then this is fine with me. r=LpSolit

Comment 5

[David Lawrence [:dkl]]

(In reply to Frédéric Buclin from comment #4)
> Comment on attachment 8706973 [details] [diff] [review]
> 1238987_2.patch
> 
> I didn't test your patch. But if this fixes the problem for you, then this
> is fine with me. r=LpSolit

It does fix the problem, yes :)

Comment 6

[David Lawrence [:dkl]]

To ssh://[e-mail]/bugzilla/bugzilla.git
   9c29ca8..2db58cf  master -> master