Closed Bug 1239008 Opened 4 years ago Closed 4 months ago

Remove unused ChromeDebuggerActor

Categories

(DevTools :: Debugger, task, P3)

task

Tracking

(firefox46 wontfix, firefox73 fixed)

RESOLVED FIXED
Firefox 73
Tracking Status
firefox46 --- wontfix
firefox73 --- fixed

People

(Reporter: linclark, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

See Bug #1037992
Attached patch Bug1239008.patchSplinter Review
This converts ChromeDebuggerActor and moves it to its own file.

It also changes the signature because the first parameter (connection) wasn't used anywhere.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e22637aab3e1
Attachment #8707063 - Flags: review?(jryans)
Blocks: 1037992
Keywords: checkin-needed
Comment on attachment 8707063 [details] [diff] [review]
Bug1239008.patch

Canceling out the r+ on this because the patch did actually make things fail.
Attachment #8707063 - Flags: review+
Severity: normal → enhancement
Whiteboard: [devtools-html]
No longer blocks: devtools-html-phase2
Whiteboard: [devtools-html]
Product: Firefox → DevTools
Type: enhancement → task
Priority: -- → P3

The ChromeDebuggerActor extends the methods from threadActor but didn't have an event
emitter. I updated it to function the same as other actors

Attachment #9072543 - Attachment is obsolete: true

It looks like this actor is still in-tree but no longer used.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Summary: Change ChromeDebuggerActor to protocol.js → Remove unused ChromeDebuggerActor
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e5983cf83dce
Remove unused ChromeDebuggerActor. r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
You need to log in before you can comment on or make changes to this bug.