Closed Bug 1239132 Opened 4 years ago Closed 3 years ago

Intermittent browser_markup_dragdrop_reorder.js | Uncaught exception - at :0 - Error: operation not possible on dead CPOW

Categories

(DevTools :: Inspector, defect, P2)

defect

Tracking

(e10s+, firefox49 unaffected, firefox50 fixed, firefox51 fixed)

RESOLVED FIXED
Firefox 51
Tracking Status
e10s + ---
firefox49 --- unaffected
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: KWierso, Assigned: jsnajdr)

References

(Blocks 2 open bugs)

Details

(Keywords: intermittent-failure, Whiteboard: [btpp-backlog])

Attachments

(1 file)

Triaging (filter on CLIMBING SHOES).
Priority: -- → P3
Whiteboard: [btpp-backlog]
Triaging (filter on CLIMBING SHOES).
Priority: P3 → P2
The wait() function in shared-head.js calls "content.setTimeout", which is a CPOW access that's not needed at all. Changed to just "setTimeout", and removed duplicate definitions of "wait" from head.js files that already include shared-head.js.
Assignee: nobody → jsnajdr
Blocks: 1296849
Blocks: 1295426
Comment on attachment 8790192 [details]
Bug 1239132 - Remove CPOW access from 'wait' function in shared-head.js

https://reviewboard.mozilla.org/r/78122/#review76682

Thanks for the cleanup Jarda.
I have no idea why we had been using content.setTimeout in the first place ...
Attachment #8790192 - Flags: review?(pbrosset) → review+
(In reply to Patrick Brosset <:pbro> (at ViewSource conf Sept. 12-14) from comment #25)
> I have no idea why we had been using content.setTimeout in the first place

My theory is that it's a leftover from pre-e10s era where accessing "content" was free, and the "setTimeout" symbol was not readily available in chrome - you'd have to require("sdk/timers")
Pushed by jsnajdr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/47a1480e715d
Remove CPOW access from 'wait' function in shared-head.js r=pbro
https://hg.mozilla.org/mozilla-central/rev/47a1480e715d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.