Closed Bug 1239137 Opened 4 years ago Closed 4 years ago

BasicCompositor + 3d transforms give GraphicsCriticalError: |[0][GFX1-]: Failed to allocate a surface due to invalid size (DSS) Size(0,0)

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox45 --- fixed
firefox46 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(1 file)

STR:
 1. Use BasicCompositor.
 2. Go to http://tympanus.net/Development/SeatPreview/

In the console you'll see lots of warnings like this:
> Crash Annotation GraphicsCriticalError: |[0][GFX1-]: Failed to allocate a surface due to invalid size (DSS) Size(0,0)

This is because BasicCompositor::DrawQuad tries to allocate a 0x0 surface for 3d transforming, because transformBounds is empty.
Comment on attachment 8707179 [details]
MozReview Request: Bug 1239137 - Return early from BasicCompositor::DrawQuad if transformBounds is empty. r?mattwoodrow

https://reviewboard.mozilla.org/r/30601/#review27407
Attachment #8707179 - Flags: review?(matt.woodrow) → review+
Duplicate of this bug: 1065013
https://hg.mozilla.org/mozilla-central/rev/1e601b1fcfe8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Should we take this on Aurora too?
Flags: needinfo?(mstange)
Comment on attachment 8707179 [details]
MozReview Request: Bug 1239137 - Return early from BasicCompositor::DrawQuad if transformBounds is empty. r?mattwoodrow

Yeah, let's do it.

Approval Request Comment
[Feature/regressing bug #]: BasicCompositor
[User impact if declined]: spurious warning messages in the console and in crash reports
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: very low, just avoids us calling functions that wouldn't do anything other than erroring out anyway
[String/UUID change made/needed]: none
Flags: needinfo?(mstange)
Attachment #8707179 - Flags: approval-mozilla-aurora?
Comment on attachment 8707179 [details]
MozReview Request: Bug 1239137 - Return early from BasicCompositor::DrawQuad if transformBounds is empty. r?mattwoodrow

Remove a irrelevant warning, taking it (I experienced it myself)
Attachment #8707179 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.