1239162 - Intermittent test_FrameSelection.html | application crashed [@ pthread_mutex_lock_impl]

Status: RESOLVED DUPLICATE of bug 1116473

(Core :: Graphics: Layers, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://treeherder.mozilla.org/logviewer.html#?job_id=19671950&repo=mozilla-inbound

Comment 1

[Intermittent Failures Robot]

5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 2
* mozilla-aurora: 2
* mozilla-central: 1

Platform breakdown:
* android-4-3-armv7-api11: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1239162&startday=2016-01-11&endday=2016-01-17&tree=all

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

 2  libxul.so!mozilla::OffTheBooksMutex::Lock [BlockingResourceBase.cpp:672b054df145 : 382 + 0x5]
 3  libxul.so!mozilla::gl::AndroidSurfaceTexture::Attach [Monitor.h:672b054df145 : 35 + 0x3]
 4  libxul.so!mozilla::layers::SurfaceTextureHost::Lock [TextureHostOGL.cpp:672b054df145 : 476 + 0x5]
 5  libxul.so!mozilla::layers::ImageHost::Lock [ImageHost.cpp:672b054df145 : 516 + 0x3]
 6  libxul.so!mozilla::layers::AutoLockCompositableHost::AutoLockCompositableHost [CompositableHost.h:672b054df145 : 255 + 0x3]
 7  libxul.so!mozilla::layers::ImageHost::Composite [ImageHost.cpp:672b054df145 : 313 + 0x7]
 8  libxul.so + 0x9cf8a7
 9  libxul.so!mozilla::layers::RenderWithAllMasks<mozilla::layers::ImageLayerComposite::RenderLayer(const IntRect&)::<lambda(mozilla::layers::EffectChain&, const Rect&)> > [LayerManagerComposite.h:672b054df145 : 566 + 0x9]
10  libxul.so!mozilla::layers::ImageLayerComposite::RenderLayer [ImageLayerComposite.cpp:672b054df145 : 105 + 0xd]
11  libxul.so!mozilla::layers::RenderLayers<mozilla::layers::ContainerLayerComposite> [ContainerLayerComposite.cpp:672b054df145 : 577 + 0x1]
12  libxul.so!mozilla::layers::ContainerRender<mozilla::layers::ContainerLayerComposite> [ContainerLayerComposite.cpp:672b054df145 : 741 + 0x3]
13  libxul.so!mozilla::layers::RenderLayers<mozilla::layers::ContainerLayerComposite> [ContainerLayerComposite.cpp:672b054df145 : 577 + 0x1]
14  libxul.so!mozilla::layers::ContainerRender<mozilla::layers::ContainerLayerComposite> [ContainerLayerComposite.cpp:672b054df145 : 741 + 0x3]
15  libxul.so!mozilla::layers::LayerManagerComposite::Render [LayerManagerComposite.cpp:672b054df145 : 871 + 0x1]
16  libxul.so!mozilla::layers::LayerManagerComposite::UpdateAndRender [LayerManagerComposite.cpp:672b054df145 : 445 + 0x7]
17  libxul.so!mozilla::layers::LayerManagerComposite::EndTransaction [LayerManagerComposite.cpp:672b054df145 : 367 + 0x5]
18  libxul.so!mozilla::layers::CompositorParent::CompositeToTarget [CompositorParent.cpp:672b054df145 : 1175 + 0x7]
19  libxul.so!mozilla::layers::CompositorVsyncScheduler::Composite [CompositorParent.cpp:672b054df145 : 441 + 0x5]

Looks like a bug of gfx...

Comment 3

[Intermittent Failures Robot]

7 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 4
* mozilla-aurora: 3

Platform breakdown:
* android-4-3-armv7-api11: 7

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1239162&startday=2016-01-18&endday=2016-01-24&tree=all

Comment 4

[Intermittent Failures Robot]

12 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 4
* mozilla-beta: 4
* fx-team: 2
* try: 1
* mozilla-central: 1

Platform breakdown:
* android-4-3-armv7-api15: 6
* android-4-3-armv7-api11: 4
* windows8-64: 1
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1239162&startday=2016-02-08&endday=2016-02-14&tree=all

Comment 5

[Peter Chang[:pchang]]

Based on comment 2, I guess the android surface texture(mSurfTex) already got free in the client side but still be used in host side because we use raw ptr to save this texture[1].

[1]https://dxr.mozilla.org/mozilla-central/source/gfx/layers/opengl/TextureHostOGL.h#417

I will use RefPtr to save this texture to see it is still reproduced or not.

Comment 6

[Peter Chang[:pchang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba941037d1c3

Comment 7

[Peter Chang[:pchang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc3f02ec622e

Comment 8

[Peter Chang[:pchang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=726caaadc3c5

Comment 9

[Peter Chang[:pchang]]

Attachment: MozReview Request: Bug 1239162 Keep android surfacetexture during the lifecycle of texture host, r?nical

Review commit: https://reviewboard.mozilla.org/r/35385/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35385/

Comment 10

[Peter Chang[:pchang]]

(In reply to peter chang[:pchang][:peter] from comment #9)
> Created attachment 8720625 [details]
> MozReview Request: Bug 1239162 Keep android surfacetexture during the
> lifecycle of texture host, r?nical
> 
> Review commit: https://reviewboard.mozilla.org/r/35385/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/35385/

With this patch, I can't reproduce this in comment 7.

Comment 11

[Peter Chang[:pchang]]

(In reply to peter chang[:pchang][:peter] from comment #9)
> Created attachment 8720625 [details]
> MozReview Request: Bug 1239162 Keep android surfacetexture during the
> lifecycle of texture host, r?nical
> 
> Review commit: https://reviewboard.mozilla.org/r/35385/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/35385/

I believe this crash was caused by the android surface texture got destroyed in client side(ActorDestory), but it was used during the composition. So keep this android surfacetexutre inside texture host should fix this problem.

Comment 12

[Peter Chang[:pchang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ccf40de42091

Comment 13

[Nicolas Silva [:nical]]

Comment on attachment 8720625 [details]
MozReview Request: Bug 1239162 Keep android surfacetexture during the lifecycle of texture host, r?nical

https://reviewboard.mozilla.org/r/35385/#review32673

r+ with 1 modification: Please override DeallocateDeviceData so that it nulls out the RefPtr. In some rare cases, textures happen to be held alive just a bit longer than the widget during shutdown, which can cause some gpu resources to outlive the widget's gl context and that's bad. So we should avoid adding string references to gl resources that may outlive the widget and DeallocateDeviceData should take care of that.

Comment 15

[Peter Chang[:pchang]]

(In reply to Nicolas Silva [:nical] from comment #13)
> Comment on attachment 8720625 [details]
> MozReview Request: Bug 1239162 Keep android surfacetexture during the
> lifecycle of texture host, r?nical
> 
> https://reviewboard.mozilla.org/r/35385/#review32673
> 
> r+ with 1 modification: Please override DeallocateDeviceData so that it
> nulls out the RefPtr. In some rare cases, textures happen to be held alive
> just a bit longer than the widget during shutdown, which can cause some gpu
> resources to outlive the widget's gl context and that's bad. So we should
> avoid adding string references to gl resources that may outlive the widget
> and DeallocateDeviceData should take care of that.
Just found this problem was addressed by bug 1116473.
But I will create another bug to address reviewer's comment in comment 13.