1239239 - Remove ftp/file tree view support from SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Masatoshi Kimura [:emk]]

It will become a dead code once XUL directory viewer has been removed from m-c.

Comment 1

[Tony Mechelynck [:tonymec]]

Attachment: Example of a "file" directory

(In reply to Masatoshi Kimura [:emk] from comment #0)
> It will become a dead code once XUL directory viewer has been removed from
> m-c.

According to bug 1223272 comment #3, "this feature is disabled by default even in SeaMonkey with no UI to turn it back on." How come then, that browsing to a file: or ftp: directory gives me something like this? (This is with file:, ftp: is vey similar). Maybe there is a pref in about:config for it, but I don't know which one. I tried toggling a couple of prefs which I thought might be related but they didn't change anything.

UA:"Mozilla/5.0 (X11; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0 SeaMonkey/2.43a1"
ID:20160109003001 en-US
c-c:4f4f6a3674c9e16efacf62fd8963c8be5a31b07c
m-c:0f363ae95dc90d593394ef464aa500804c824962

Comment 2

[Masatoshi Kimura [:emk]]

(In reply to Tony Mechelynck [:tonymec] from comment #1)
> According to bug 1223272 comment #3, "this feature is disabled by default
> even in SeaMonkey with no UI to turn it back on." How come then, that
> browsing to a file: or ftp: directory gives me something like this? (This is
> with file:, ftp: is vey similar). Maybe there is a pref in about:config for
> it, but I don't know which one. I tried toggling a couple of prefs which I
> thought might be related but they didn't change anything.

Please change "network.dir.format" to 3 and then browse any ftp/local directories.
I confirmed it with SeaMonkey 2.39 release.

Comment 3

[Tony Mechelynck [:tonymec]]

(In reply to Masatoshi Kimura [:emk] from comment #2)
> (In reply to Tony Mechelynck [:tonymec] from comment #1)
> > According to bug 1223272 comment #3, "this feature is disabled by default
> > even in SeaMonkey with no UI to turn it back on." How come then, that
> > browsing to a file: or ftp: directory gives me something like this? (This is
> > with file:, ftp: is vey similar). Maybe there is a pref in about:config for
> > it, but I don't know which one. I tried toggling a couple of prefs which I
> > thought might be related but they didn't change anything.
> 
> Please change "network.dir.format" to 3 and then browse any ftp/local
> directories.
> I confirmed it with SeaMonkey 2.39 release.

Oh, beeyootiful! With that value, the directory is displayed in tree format, like the Bookmarks Manager, also in 2.43a1 trunk.

Does it mean that if and when this bug gets "fixed", SeaMonkey won't have a (tree-like) Bookmarks Manager anymore?

Comment 4

[Masatoshi Kimura [:emk]]

(In reply to Tony Mechelynck [:tonymec] from comment #3)
> Does it mean that if and when this bug gets "fixed", SeaMonkey won't have a
> (tree-like) Bookmarks Manager anymore?

Probably no, although I didn't dig into the SeaMonkey source tree deeply. The XUL Directory Viewer uses a hard-coded URL, "chrome://communicator/content/directory/directory.xul". Removing this file will not affect Bookmarks Manager.

Comment 5

[Philip Chee]

(In reply to Jonas Sicking (:sicking) from Bug 1223272 comment #2)
> It's not that I don't care about comm-central. But given that this is a
> seamonkey specific feature, it should live in the seamonkey tree. Especially
> given that this is quite a lot of code.
> 
> Looks like this code is using enough XPCOM that seamonkey can override the
> relevant contracts/categories and copy this code into there.

Neil, would you be opposed to copying the XPCOM component into comm-central/suite?

Comment 6

[[e-mail]]

(In reply to Philip Chee from comment #5)
> Neil, would you be opposed to copying the XPCOM component into
> comm-central/suite?

No, but it probably wouldn't be a straight copy - the m-c component would have used the internal API but suite.dll uses the external API. (Maybe the code could be rewritten in JavaScript? I'd have to find time to look into that...)

Comment 7

[Philip Chee]

Attachment: WIP patch (not working yet) copy files to /suite/common/directory/

Comment 8

[Philip Chee]

TODO: Find out how to override the XPFE directory viewer.

Comment 9

[Philip Chee]

It occurs to me that once jcranmer gets a merged comm-central/mozilla-central we can just back out Bug 1223272 in merged-comm-central.

Comment 10

[Frank-Rainer Grahl (:frg)]

nsFileSystemDataSource is gone and we decided to remove it in bug 1412978. This would have otherwise needed a complete reimplemantation in comm-central code and all of rdf is on the way out.

Comment 11

[Frank-Rainer Grahl (:frg)]

Attachment: 1239239-part1-Removedirectoryviewer.patch

Comment 12

[Frank-Rainer Grahl (:frg)]

Attachment: 1239239-part2-Removedirectoryviewer.patch

Migration code

Comment 13

[Frank-Rainer Grahl (:frg)]

Attachment: 1239239-part3-Removedirectoryviewer.patch

debugQA preferences. I am just building now. Is this still valid after the latest round of xbl and other removals?

Comment 14

[Stefan [:stefanh]]

Comment on attachment 8944258 [details] [diff] [review]
1239239-part1-Removedirectoryviewer.patch

Looks good to me, thanks.

Comment 15

[Stefan [:stefanh]]

Comment on attachment 8944260 [details] [diff] [review]
1239239-part3-Removedirectoryviewer.patch

-<!ENTITY httpVersion.label            "HTTP Version">

Nice - this was unused.

Comment 16

[Stefan [:stefanh]]

(In reply to Frank-Rainer Grahl (:frg) from comment #13)
> Created attachment 8944260 [details] [diff] [review]
> 1239239-part3-Removedirectoryviewer.patch
> 
> debugQA preferences. I am just building now. Is this still valid after the
> latest round of xbl and other removals?

Should work fine, but I haven't checked.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4f56e21c7e3a
Part 1. Remove ftp/file tree view support from SeaMonkey. r=stefanh
https://hg.mozilla.org/comm-central/rev/fd0fd7d28d8c
Part 2. Set network.dir.format to a valid value after removal of the XUL directory viewer. r=stefanh
https://hg.mozilla.org/comm-central/rev/54533507e7b2
Part 3. Pref network.dir.format should no longer be changeable. Option 3 has been removed. r=stefanh