Closed Bug 1239241 Opened 8 years ago Closed 8 years ago

Facebook SEND button in conversation window when waiting alone

Categories

(Hello (Loop) :: Client, defect, P2)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Iteration:
47.2 - Feb 22

People

(Reporter: RT, Assigned: fcampo)

References

Details

User Story

As a desktop client user in a conversation, I want to send the conversation URL using Facebook through direct messenger messages.

We had a previous implementation which used Facebook Share, this was not satisfactory since the Facebook share dialogue opens in a new tab (we want a pop-up) and defaults to sharing on the Facebook timeline (we want to default to "in a private message")
Initial Facebook share bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1178304 

Acceptance criteria:
- Facebook send button always available in the conversation window when waiting alone
- The Facebook send button opens a pop-up where the Facebook send dialogue is
- Previous implementation using the Facebook share button removed (bug 1178304)
- Clicking the Facebook share button opens the Facebook  send dialogue in a pop-up window with the following pre-populated (using open graph tags: https://developers.facebook.com/docs/sharing/best-practices):
--- A 1200 x 630 pixels image promoting Firefox Hello
--- Message: [Filled-in by the user]
--- The message: "I would like to browse [populate website domain here] with you"
--- Link: <Conversation URL>
--- app_id: TBD (currently blocking the implementation)
- Clicks on the Facebook button trigger a Telemetry event (opt-out) to understand usage of the feature

Attachments

(1 file)

[loop] fcampo:fb-send-1239241 > mozilla:master
40 bytes, text/x-github-pull-request
mancas
: review+
Details | Review 
      No description provided.
User Story: (updated)
Rank: 21
Priority: -- → P2
RT/Ian: I *think* we need an app_id for this before we start working on it. I believe RT was going to sort this out.

Bumping down the priority list until we've got an understanding about the app_id.
Rank: 21 → 29
Flags: needinfo?(rtestard)
Flags: needinfo?(ianb)
Whiteboard: [blocked]
Assignee: nobody → fernando.campo
I checked and as apparently it's not possible to change the ID of an app once its created, I propose to create an app_id with any dev account (I can do it if no other volunteers), and transfer ownership later on, it's easy to move the ID from one developer to another.
hmmmmm, just discovered that for testing, it works with ANY valid app_id, no matter if assigned to your app or other. Weird. But useful.

It also needs a redirect_uri, which is the webpage that (as a link generator) you will be redirected after you click the send button. It does not close the new tab automatically, but guess we can link to local page with a window.close script?
We have an App ID for Hello specifically: 205089086505067
Flags: needinfo?(ianb)
For reference if we need to update the APp ID: the App ID is attached to the Firefox Facebook profile.  Elizabeth Hull manages that profile and allocated the ID for us.
(In reply to Ian Bicking (:ianb) from comment #4)
> We have an App ID for Hello specifically: 205089086505067
I'm getting an error when I try to use that app_id, 
and the message is not very helpful "An error occurred. Please try later"

It's definitely related to app_id, as all the rest tested works, can we double check that it is correct?
Flags: needinfo?(ianb)
I think we should bump the priority up again
Whiteboard: [blocked] → [triage]
Rank: 29 → 24
Flags: needinfo?(ianb)
Whiteboard: [triage]
Flags: needinfo?(rtestard)
After discussions we decided a new app ID will be created under a private account (Fernando) and then shared with Elizabeth.
Attachment #8717877 - Flags: review?(edilee)
Attachment #8717877 - Flags: review?(crafuse)
Attachment #8717877 - Flags: review?(crafuse) → review?(b.mcb)
Comment on attachment 8717877 [details] [review]
[loop] fcampo:fb-send-1239241 > mozilla:master

Looks good to me with comments addressed.

Thanks
Attachment #8717877 - Flags: review?(b.mcb) → review+
Comments from Ed and Manu addressed. Thanks both for review.
Keywords: checkin-needed
Attachment #8717877 - Flags: review?(edilee)
Attachment #8717877 - Flags: review?(crafuse)
Blocks: 1248526
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: