We should download the xulrunner from taskcluster artifact instead of people.mozilla.org

RESOLVED FIXED in Firefox 46

Status

P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: edgar, Assigned: edgar)

Tracking

unspecified
mozilla46
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
+++ This bug was initially created as a follow-up of Bug #1207548 +++

Somehow the wrong patch is pushed in bug 1207548.
We should download the xulrunner from taskcluster artifact which is provided by garndt in bug 1207548 comment 7.
(Assignee)

Comment 1

3 years ago
Created attachment 8707369 [details]
MozReview Request: Bug 1239261 - We should download the xulrunner from taskcluster artifact instead of people.mozilla.org; r?garndt

Review commit: https://reviewboard.mozilla.org/r/30655/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30655/
(Assignee)

Updated

3 years ago
Assignee: nobody → echen
(Assignee)

Updated

3 years ago
Attachment #8707369 - Flags: review?(garndt)
(Assignee)

Updated

3 years ago
Attachment #8707369 - Flags: review?(garndt)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8707369 [details]
MozReview Request: Bug 1239261 - We should download the xulrunner from taskcluster artifact instead of people.mozilla.org; r?garndt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/30655/diff/1-2/
Attachment #8707369 - Attachment description: MozReview Request: Bug 1239261 - We should download the xulrunner from taskcluster artifact instead of people.mozilla.org → MozReview Request: Bug 1239261 - We should download the xulrunner from taskcluster artifact instead of people.mozilla.org; r?garndt
Attachment #8707369 - Flags: review?(garndt)

Updated

3 years ago
Attachment #8707369 - Flags: review?(garndt) → review+

Comment 4

3 years ago
Comment on attachment 8707369 [details]
MozReview Request: Bug 1239261 - We should download the xulrunner from taskcluster artifact instead of people.mozilla.org; r?garndt

https://reviewboard.mozilla.org/r/30655/#review27679

::: testing/taskcluster/tasks/tests/b2g_emulator_mochitest.yml:25
(Diff revision 2)
> -        --xre-url http://people.mozilla.org/~jdai/xulrunner-sdk-40.zip
> +        --xre-url https://queue.taskcluster.net/v1/task/YNNF94qRSyCXiSU_AQgFOQ/runs/0/artifacts/public/cache/xulrunner-sdk-40.zip

Just something to keep in mind that when using a task artifact there is an expiration associated with it.  This particular one will expired on 2016-09-24T16:33:35.723Z and no longer be able to be retrieved.
(Assignee)

Comment 5

3 years ago
(In reply to Greg Arndt [:garndt] from comment #4)
> Comment on attachment 8707369 [details]
> MozReview Request: Bug 1239261 - We should download the xulrunner from
> taskcluster artifact instead of people.mozilla.org; r?garndt
> 
> https://reviewboard.mozilla.org/r/30655/#review27679
> 
> ::: testing/taskcluster/tasks/tests/b2g_emulator_mochitest.yml:25
> (Diff revision 2)
> > -        --xre-url http://people.mozilla.org/~jdai/xulrunner-sdk-40.zip
> > +        --xre-url https://queue.taskcluster.net/v1/task/YNNF94qRSyCXiSU_AQgFOQ/runs/0/artifacts/public/cache/xulrunner-sdk-40.zip
> 
> Just something to keep in mind that when using a task artifact there is an
> expiration associated with it.  This particular one will expired on
> 2016-09-24T16:33:35.723Z and no longer be able to be retrieved.

Thanks for this information. So maybe we should move it to tooltool. I will file a follow-up bug for that. Thank you.
(Assignee)

Updated

3 years ago
Blocks: 1239903

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f19dcbff4237
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.