Delays don't have the right size in the animation timeline

RESOLVED FIXED in Firefox 46

Status

RESOLVED FIXED
3 years ago
4 months ago

People

(Reporter: pbro, Assigned: pbro)

Tracking

unspecified
Firefox 46

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
In bug 1171863 the whole UI of the timeline was changed from pixel units to percentages, so that it would resize when the sidebar was resized.

Unfortunately, some elements of the timeline are nested into each other, so 50% of something that's already 50% of the timeline width will end up being 25%.
This was overlooked in bug 1171863 as I simply changed px to %.

We need to rework the way the elements are nested in the timeline to avoid this.
An animation iteration 1% wide should be as wide as an animation delay of 1%.
(Assignee)

Updated

3 years ago
Assignee: nobody → pbrosset
(Assignee)

Comment 1

3 years ago
Created attachment 8707420 [details]
MozReview Request: Bug 1239298 - Make sure percentage width of iterations and delays in the timeline are relative to the same parent

Review commit: https://reviewboard.mozilla.org/r/30685/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30685/
Attachment #8707420 - Flags: review?(mratcliffe)
(Assignee)

Comment 2

3 years ago
Comment on attachment 8707420 [details]
MozReview Request: Bug 1239298 - Make sure percentage width of iterations and delays in the timeline are relative to the same parent

Mike is on PTO these days, perhaps Tom could review this?
Attachment #8707420 - Flags: review?(mratcliffe) → review?(ttromey)

Comment 4

3 years ago
Comment on attachment 8707420 [details]
MozReview Request: Bug 1239298 - Make sure percentage width of iterations and delays in the timeline are relative to the same parent

https://reviewboard.mozilla.org/r/30685/#review27689

This looks reasonable to me.  I noticed, though, that there is no associated test.  If this is impractical, then it's ok; but otherwise something is needed.
Attachment #8707420 - Flags: review?(ttromey) → review+
(Assignee)

Comment 5

3 years ago
(In reply to Tom Tromey :tromey from comment #4)
> This looks reasonable to me.  I noticed, though, that there is no associated
> test.  If this is impractical, then it's ok; but otherwise something is
> needed.
So we do have a few tests that ensure delay elements are positioned correctly in the timeline. So at least, if these still pass, there won't be any regressions related to where and how wide delays are shown.

Now, there's been quite a bunch of HTML restructuring and CSS changes here, so there could theoritically be regressions related to the visual aspect of delay elements, but so far in devtools we've never had any sort of automated visual tests, so I don't think I can add anything here.

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/436190769b9e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46

Comment 8

3 years ago
[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.